Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pinctrl: nomadik: abx500: Add of_node_put() before return

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190804155154.4916-1-nishkadg.linux@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

authored by

Nishka Dasgupta and committed by
Linus Walleij
f4524447 ea8cf5c5

+1
+1
drivers/pinctrl/nomadik/pinctrl-abx500.c
··· 815 815 &reserved_maps, num_maps); 816 816 if (ret < 0) { 817 817 pinctrl_utils_free_map(pctldev, *map, *num_maps); 818 + of_node_put(np); 818 819 return ret; 819 820 } 820 821 }