Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: dsa: Explicitly include correct DT includes

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20230724211859.805481-1-robh@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Rob Herring and committed by
Jakub Kicinski
f44a9010 601ad04f

+17 -10
+1
drivers/net/dsa/b53/b53_mdio.c
··· 19 19 #include <linux/kernel.h> 20 20 #include <linux/phy.h> 21 21 #include <linux/module.h> 22 + #include <linux/of.h> 22 23 #include <linux/delay.h> 23 24 #include <linux/brcmphy.h> 24 25 #include <linux/rtnetlink.h>
+1
drivers/net/dsa/b53/b53_mmap.c
··· 19 19 #include <linux/bits.h> 20 20 #include <linux/kernel.h> 21 21 #include <linux/module.h> 22 + #include <linux/of.h> 22 23 #include <linux/io.h> 23 24 #include <linux/platform_device.h> 24 25 #include <linux/platform_data/b53.h>
-1
drivers/net/dsa/hirschmann/hellcreek.c
··· 11 11 #include <linux/module.h> 12 12 #include <linux/device.h> 13 13 #include <linux/of.h> 14 - #include <linux/of_device.h> 15 14 #include <linux/of_mdio.h> 16 15 #include <linux/platform_device.h> 17 16 #include <linux/bitops.h>
+1
drivers/net/dsa/hirschmann/hellcreek_ptp.c
··· 9 9 * Kurt Kanzenbach <kurt@linutronix.de> 10 10 */ 11 11 12 + #include <linux/of.h> 12 13 #include <linux/ptp_clock_kernel.h> 13 14 #include "hellcreek.h" 14 15 #include "hellcreek_ptp.h"
+1
drivers/net/dsa/lan9303-core.c
··· 8 8 #include <linux/regmap.h> 9 9 #include <linux/mutex.h> 10 10 #include <linux/mii.h> 11 + #include <linux/of.h> 11 12 #include <linux/phy.h> 12 13 #include <linux/if_bridge.h> 13 14 #include <linux/if_vlan.h>
+3
drivers/net/dsa/microchip/ksz8863_smi.c
··· 5 5 * Copyright (C) 2019 Pengutronix, Michael Grzeschik <kernel@pengutronix.de> 6 6 */ 7 7 8 + #include <linux/mod_devicetable.h> 9 + #include <linux/property.h> 10 + 8 11 #include "ksz8.h" 9 12 #include "ksz_common.h" 10 13
+1 -1
drivers/net/dsa/microchip/ksz_common.c
··· 18 18 #include <linux/if_vlan.h> 19 19 #include <linux/irq.h> 20 20 #include <linux/irqdomain.h> 21 + #include <linux/of.h> 21 22 #include <linux/of_mdio.h> 22 - #include <linux/of_device.h> 23 23 #include <linux/of_net.h> 24 24 #include <linux/micrel_phy.h> 25 25 #include <net/dsa.h>
+2 -1
drivers/net/dsa/mt7530-mmio.c
··· 1 1 // SPDX-License-Identifier: GPL-2.0-only 2 2 3 + #include <linux/mod_devicetable.h> 3 4 #include <linux/module.h> 4 - #include <linux/of_platform.h> 5 + #include <linux/platform_device.h> 5 6 #include <linux/regmap.h> 6 7 #include <linux/regulator/consumer.h> 7 8 #include <linux/reset.h>
+1 -1
drivers/net/dsa/mv88e6xxx/chip.c
··· 23 23 #include <linux/list.h> 24 24 #include <linux/mdio.h> 25 25 #include <linux/module.h> 26 - #include <linux/of_device.h> 26 + #include <linux/of.h> 27 27 #include <linux/of_irq.h> 28 28 #include <linux/of_mdio.h> 29 29 #include <linux/platform_data/mv88e6xxx.h>
+1
drivers/net/dsa/ocelot/felix_vsc9959.c
··· 16 16 #include <net/pkt_sched.h> 17 17 #include <linux/iopoll.h> 18 18 #include <linux/mdio.h> 19 + #include <linux/of.h> 19 20 #include <linux/pci.h> 20 21 #include <linux/time.h> 21 22 #include "felix.h"
+2 -1
drivers/net/dsa/ocelot/seville_vsc9953.c
··· 2 2 /* Distributed Switch Architecture VSC9953 driver 3 3 * Copyright (C) 2020, Maxim Kochetkov <fido_max@inbox.ru> 4 4 */ 5 + #include <linux/platform_device.h> 5 6 #include <linux/types.h> 6 7 #include <soc/mscc/ocelot_vcap.h> 7 8 #include <soc/mscc/ocelot_sys.h> 8 9 #include <soc/mscc/ocelot.h> 9 10 #include <linux/mdio/mdio-mscc-miim.h> 11 + #include <linux/mod_devicetable.h> 10 12 #include <linux/of_mdio.h> 11 - #include <linux/of_platform.h> 12 13 #include <linux/pcs-lynx.h> 13 14 #include <linux/dsa/ocelot.h> 14 15 #include <linux/iopoll.h>
+1
drivers/net/dsa/qca/qca8k-leds.c
··· 1 1 // SPDX-License-Identifier: GPL-2.0 2 + #include <linux/property.h> 2 3 #include <linux/regmap.h> 3 4 #include <net/dsa.h> 4 5
+1 -1
drivers/net/dsa/realtek/realtek-mdio.c
··· 20 20 */ 21 21 22 22 #include <linux/module.h> 23 - #include <linux/of_device.h> 23 + #include <linux/of.h> 24 24 #include <linux/overflow.h> 25 25 #include <linux/regmap.h> 26 26
-1
drivers/net/dsa/realtek/realtek-smi.c
··· 31 31 #include <linux/spinlock.h> 32 32 #include <linux/skbuff.h> 33 33 #include <linux/of.h> 34 - #include <linux/of_device.h> 35 34 #include <linux/of_mdio.h> 36 35 #include <linux/delay.h> 37 36 #include <linux/gpio/consumer.h>
-1
drivers/net/dsa/sja1105/sja1105_main.c
··· 15 15 #include <linux/of.h> 16 16 #include <linux/of_net.h> 17 17 #include <linux/of_mdio.h> 18 - #include <linux/of_device.h> 19 18 #include <linux/pcs/pcs-xpcs.h> 20 19 #include <linux/netdev_features.h> 21 20 #include <linux/netdevice.h>
-1
drivers/net/dsa/vitesse-vsc73xx-core.c
··· 18 18 #include <linux/module.h> 19 19 #include <linux/device.h> 20 20 #include <linux/of.h> 21 - #include <linux/of_device.h> 22 21 #include <linux/of_mdio.h> 23 22 #include <linux/bitops.h> 24 23 #include <linux/if_bridge.h>
+1 -1
drivers/net/dsa/xrs700x/xrs700x.c
··· 7 7 #include <net/dsa.h> 8 8 #include <linux/etherdevice.h> 9 9 #include <linux/if_bridge.h> 10 - #include <linux/of_device.h> 10 + #include <linux/of.h> 11 11 #include <linux/netdev_features.h> 12 12 #include <linux/if_hsr.h> 13 13 #include "xrs700x.h"