Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

leds: lp3952: Use 'if (ret)' pattern

Instead of unusual "if (!ret)" use "if (ret)" in lp3952_get_label().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>

authored by

Andy Shevchenko and committed by
Jacek Anaszewski
f4363d81 96962178

+4 -3
+4 -3
drivers/leds/leds-lp3952.c
··· 102 102 const char *str; 103 103 104 104 ret = device_property_read_string(dev, label, &str); 105 - if (!ret) 106 - strncpy(dest, str, LP3952_LABEL_MAX_LEN); 105 + if (ret) 106 + return ret; 107 107 108 - return ret; 108 + strncpy(dest, str, LP3952_LABEL_MAX_LEN); 109 + return 0; 109 110 } 110 111 111 112 static int lp3952_register_led_classdev(struct lp3952_led_array *priv)