Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

lightnvm: prevent race condition on pblk remove

When we trigger nvm target remove during device hot unplug, there is
a probability to hit a general protection fault. This is caused by use
of nvm_dev thay may be freed from another (hot unplug) thread
(in the nvm_unregister function).

Introduce lock in nvme_ioctl_dev_remove function to prevent this
situation.

Signed-off-by: Marcin Dziegielewski <marcin.dziegielewski@intel.com>
Reviewed-by: Javier González <javier@javigon.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

Marcin Dziegielewski and committed by
Jens Axboe
f41d427c 4bbae699

+2
+2
drivers/lightnvm/core.c
··· 1340 1340 return -EINVAL; 1341 1341 } 1342 1342 1343 + down_read(&nvm_lock); 1343 1344 list_for_each_entry(dev, &nvm_devices, devices) { 1344 1345 ret = nvm_remove_tgt(dev, &remove); 1345 1346 if (!ret) 1346 1347 break; 1347 1348 } 1349 + up_read(&nvm_lock); 1348 1350 1349 1351 return ret; 1350 1352 }