Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tty/early: make serial8250_early_{in,out} static again

Commit ed71871bed719 ("tty/8250_early: Turn serial_in/serial_out into
weak symbols") made these routines weak to allow platform specific
Big endian override

However recent updates to core, specifically ebc5e20082 ("serial:
of_serial: Support big-endian register accesses") and 6e63be3fee14
("serial: earlycon: Add support for big-endian MMIO accesses") means
that round about way to overide the early serial accessors is no longer
needed.

Cc: Jiri Slaby <jslaby@suse.cz>
Cc: Peter Hurley <peter@hurleysoftware.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Kevin Cernekee <cernekee@gmail.com>
Acked-by: Noam Camus <noamc@ezchip.com>
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Vineet Gupta and committed by
Greg Kroah-Hartman
f3fb7ef3 b6830f6d

+2 -4
+2 -2
drivers/tty/serial/8250/8250_early.c
··· 35 35 #include <asm/io.h> 36 36 #include <asm/serial.h> 37 37 38 - unsigned int __weak __init serial8250_early_in(struct uart_port *port, int offset) 38 + static unsigned int __init serial8250_early_in(struct uart_port *port, int offset) 39 39 { 40 40 switch (port->iotype) { 41 41 case UPIO_MEM: ··· 51 51 } 52 52 } 53 53 54 - void __weak __init serial8250_early_out(struct uart_port *port, int offset, int value) 54 + static void __init serial8250_early_out(struct uart_port *port, int offset, int value) 55 55 { 56 56 switch (port->iotype) { 57 57 case UPIO_MEM:
-2
include/linux/serial_8250.h
··· 136 136 137 137 extern int early_serial_setup(struct uart_port *port); 138 138 139 - extern unsigned int serial8250_early_in(struct uart_port *port, int offset); 140 - extern void serial8250_early_out(struct uart_port *port, int offset, int value); 141 139 extern int early_serial8250_setup(struct earlycon_device *device, 142 140 const char *options); 143 141 extern void serial8250_do_set_termios(struct uart_port *port,