Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

spmi: mtk-pmif: Reorder driver remove sequence

This driver enables clocks and then adds SPMI controller in probing, so
we expect the reversed sequence in removal.
Fix the order in the remove callback.

Signed-off-by: Fei Shao <fshao@chromium.org>
Link: https://lore.kernel.org/r/20230824104101.4083400-4-fshao@chromium.org
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20231206231733.4031901-6-sboyd@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Fei Shao and committed by
Greg Kroah-Hartman
f3e67fc4 ffdfbafd

+1 -1
+1 -1
drivers/spmi/spmi-mtk-pmif.c
··· 515 515 struct spmi_controller *ctrl = platform_get_drvdata(pdev); 516 516 struct pmif *arb = spmi_controller_get_drvdata(ctrl); 517 517 518 + spmi_controller_remove(ctrl); 518 519 clk_bulk_disable_unprepare(arb->nclks, arb->clks); 519 520 clk_bulk_put(arb->nclks, arb->clks); 520 - spmi_controller_remove(ctrl); 521 521 } 522 522 523 523 static const struct of_device_id mtk_spmi_match_table[] = {