Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/msm: Don't use autosuspend for display

No functional change, as we only actually enable autosuspend for the GPU
device. But lets not encourage thinking that autosuspend is a good idea
for anything display related.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20211215175910.1744151-1-robdclark@gmail.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>

+8 -8
+4 -4
drivers/gpu/drm/msm/dsi/dsi_host.c
··· 2020 2020 /* TODO: unvote for bus bandwidth */ 2021 2021 2022 2022 cfg_hnd->ops->link_clk_disable(msm_host); 2023 - pm_runtime_put_autosuspend(&msm_host->pdev->dev); 2023 + pm_runtime_put(&msm_host->pdev->dev); 2024 2024 } 2025 2025 2026 2026 int msm_dsi_host_cmd_tx(struct mipi_dsi_host *host, ··· 2252 2252 */ 2253 2253 /* if (msm_panel->mode == MSM_DSI_CMD_MODE) { 2254 2254 * dsi_link_clk_disable(msm_host); 2255 - * pm_runtime_put_autosuspend(&msm_host->pdev->dev); 2255 + * pm_runtime_put(&msm_host->pdev->dev); 2256 2256 * } 2257 2257 */ 2258 2258 msm_host->enabled = true; ··· 2344 2344 2345 2345 fail_disable_clk: 2346 2346 cfg_hnd->ops->link_clk_disable(msm_host); 2347 - pm_runtime_put_autosuspend(&msm_host->pdev->dev); 2347 + pm_runtime_put(&msm_host->pdev->dev); 2348 2348 fail_disable_reg: 2349 2349 dsi_host_regulator_disable(msm_host); 2350 2350 unlock_ret: ··· 2371 2371 pinctrl_pm_select_sleep_state(&msm_host->pdev->dev); 2372 2372 2373 2373 cfg_hnd->ops->link_clk_disable(msm_host); 2374 - pm_runtime_put_autosuspend(&msm_host->pdev->dev); 2374 + pm_runtime_put(&msm_host->pdev->dev); 2375 2375 2376 2376 dsi_host_regulator_disable(msm_host); 2377 2377
+1 -1
drivers/gpu/drm/msm/dsi/phy/dsi_phy.c
··· 602 602 static void dsi_phy_disable_resource(struct msm_dsi_phy *phy) 603 603 { 604 604 clk_disable_unprepare(phy->ahb_clk); 605 - pm_runtime_put_autosuspend(&phy->pdev->dev); 605 + pm_runtime_put(&phy->pdev->dev); 606 606 } 607 607 608 608 static const struct of_device_id dsi_phy_dt_match[] = {
+1 -1
drivers/gpu/drm/msm/hdmi/hdmi_bridge.c
··· 69 69 if (ret) 70 70 DRM_DEV_ERROR(dev->dev, "failed to disable pwr regulator: %d\n", ret); 71 71 72 - pm_runtime_put_autosuspend(&hdmi->pdev->dev); 72 + pm_runtime_put(&hdmi->pdev->dev); 73 73 } 74 74 75 75 #define AVI_IFRAME_LINE_NUMBER 1
+2 -2
drivers/gpu/drm/msm/hdmi/hdmi_hpd.c
··· 205 205 msm_hdmi_set_mode(hdmi, false); 206 206 207 207 enable_hpd_clocks(hdmi, false); 208 - pm_runtime_put_autosuspend(dev); 208 + pm_runtime_put(dev); 209 209 210 210 ret = gpio_config(hdmi, false); 211 211 if (ret) ··· 260 260 hpd_int_status = hdmi_read(hdmi, REG_HDMI_HPD_INT_STATUS); 261 261 262 262 enable_hpd_clocks(hdmi, false); 263 - pm_runtime_put_autosuspend(&hdmi->pdev->dev); 263 + pm_runtime_put(&hdmi->pdev->dev); 264 264 265 265 return (hpd_int_status & HDMI_HPD_INT_STATUS_CABLE_DETECTED) ? 266 266 connector_status_connected : connector_status_disconnected;