Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: bfa: Remove unused bfa_core code

bfa_get_pciids and bfa_cfg_get_min aren't called anywhere; remove them
together with the bfa_pciid_s used by bfa_get_pciids.

(Build tested, I don't have the card)

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Link: https://lore.kernel.org/r/20240915125633.25036-2-linux@treblig.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Dr. David Alan Gilbert and committed by
Martin K. Petersen
f3845d7d 9852d85e

-45
-10
drivers/scsi/bfa/bfa.h
··· 138 138 } while (0) 139 139 140 140 141 - /* 142 - * PCI devices supported by the current BFA 143 - */ 144 - struct bfa_pciid_s { 145 - u16 device_id; 146 - u16 vendor_id; 147 - }; 148 - 149 141 extern char bfa_version[]; 150 142 151 143 struct bfa_iocfc_regs_s { ··· 400 408 (((&(_bfa)->modules.dconf_mod)->min_cfg) \ 401 409 ? BFA_LUNMASK_MINCFG : ((bfa_get_lun_mask(_bfa))->status)) 402 410 403 - void bfa_get_pciids(struct bfa_pciid_s **pciids, int *npciids); 404 411 void bfa_cfg_get_default(struct bfa_iocfc_cfg_s *cfg); 405 - void bfa_cfg_get_min(struct bfa_iocfc_cfg_s *cfg); 406 412 void bfa_cfg_get_meminfo(struct bfa_iocfc_cfg_s *cfg, 407 413 struct bfa_meminfo_s *meminfo, 408 414 struct bfa_s *bfa);
-35
drivers/scsi/bfa/bfa_core.c
··· 1934 1934 } 1935 1935 1936 1936 /* 1937 - * Return the list of PCI vendor/device id lists supported by this 1938 - * BFA instance. 1939 - */ 1940 - void 1941 - bfa_get_pciids(struct bfa_pciid_s **pciids, int *npciids) 1942 - { 1943 - static struct bfa_pciid_s __pciids[] = { 1944 - {BFA_PCI_VENDOR_ID_BROCADE, BFA_PCI_DEVICE_ID_FC_8G2P}, 1945 - {BFA_PCI_VENDOR_ID_BROCADE, BFA_PCI_DEVICE_ID_FC_8G1P}, 1946 - {BFA_PCI_VENDOR_ID_BROCADE, BFA_PCI_DEVICE_ID_CT}, 1947 - {BFA_PCI_VENDOR_ID_BROCADE, BFA_PCI_DEVICE_ID_CT_FC}, 1948 - }; 1949 - 1950 - *npciids = ARRAY_SIZE(__pciids); 1951 - *pciids = __pciids; 1952 - } 1953 - 1954 - /* 1955 1937 * Use this function query the default struct bfa_iocfc_cfg_s value (compiled 1956 1938 * into BFA layer). The OS driver can then turn back and overwrite entries that 1957 1939 * have been configured by the user. ··· 1968 1986 cfg->drvcfg.ioc_recover = BFA_FALSE; 1969 1987 cfg->drvcfg.delay_comp = BFA_FALSE; 1970 1988 1971 - } 1972 - 1973 - void 1974 - bfa_cfg_get_min(struct bfa_iocfc_cfg_s *cfg) 1975 - { 1976 - bfa_cfg_get_default(cfg); 1977 - cfg->fwcfg.num_ioim_reqs = BFA_IOIM_MIN; 1978 - cfg->fwcfg.num_tskim_reqs = BFA_TSKIM_MIN; 1979 - cfg->fwcfg.num_fcxp_reqs = BFA_FCXP_MIN; 1980 - cfg->fwcfg.num_uf_bufs = BFA_UF_MIN; 1981 - cfg->fwcfg.num_rports = BFA_RPORT_MIN; 1982 - cfg->fwcfg.num_fwtio_reqs = 0; 1983 - 1984 - cfg->drvcfg.num_sgpgs = BFA_SGPG_MIN; 1985 - cfg->drvcfg.num_reqq_elems = BFA_REQQ_NELEMS_MIN; 1986 - cfg->drvcfg.num_rspq_elems = BFA_RSPQ_NELEMS_MIN; 1987 - cfg->drvcfg.min_cfg = BFA_TRUE; 1988 1989 }