Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

i3c: dw-i3c-master: Set SIR_REJECT in DAT on device attach and reattach

The DesignWare I3C master controller ACKs IBIs as soon as a valid
Device Address Table (DAT) entry is present. This can create a race
between device attachment (after DAA) and the point where the client
driver enables IBIs via i3c_device_enable_ibi().

Set DEV_ADDR_TABLE_SIR_REJECT in the DAT entry during
attach_i3c_dev() and reattach_i3c_dev() so that IBIs are rejected
by default. The bit is managed thereafter by the existing
dw_i3c_master_set_sir_enabled() function, which clears it in
enable_ibi() after ENEC is issued, and restores it in disable_ibi()
after DISEC.

Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
Signed-off-by: Adrian Ng Ho Yin <adrianhoyin.ng@altera.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/53f5b8cbdd8af789ec38b95b02873f32f9182dd6.1770962368.git.adrianhoyin.ng@altera.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Adrian Ng Ho Yin and committed by
Alexandre Belloni
f311a057 f26ecaa0

+2 -2
+2 -2
drivers/i3c/master/dw-i3c-master.c
··· 1024 1024 master->free_pos &= ~BIT(pos); 1025 1025 } 1026 1026 1027 - writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(dev->info.dyn_addr), 1027 + writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(dev->info.dyn_addr) | DEV_ADDR_TABLE_SIR_REJECT, 1028 1028 master->regs + 1029 1029 DEV_ADDR_TABLE_LOC(master->datstartaddr, data->index)); 1030 1030 ··· 1053 1053 master->free_pos &= ~BIT(pos); 1054 1054 i3c_dev_set_master_data(dev, data); 1055 1055 1056 - writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(master->devs[pos].addr), 1056 + writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(master->devs[pos].addr) | DEV_ADDR_TABLE_SIR_REJECT, 1057 1057 master->regs + 1058 1058 DEV_ADDR_TABLE_LOC(master->datstartaddr, data->index)); 1059 1059