Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

HID: wacom: fix crash in wacom_aes_battery_handler()

Commit fd2a9b29dc9c ("HID: wacom: Remove AES power_supply after extended
inactivity") introduced wacom_aes_battery_handler() which is scheduled
as a delayed work (aes_battery_work).

In wacom_remove(), aes_battery_work is not canceled. Consequently, if
the device is removed while aes_battery_work is still pending, then hard
crashes or "Oops: general protection fault..." are experienced when
wacom_aes_battery_handler() is finally called. E.g., this happens with
built-in USB devices after resume from hibernate when aes_battery_work
was still pending at the time of hibernation.

So, take care to cancel aes_battery_work in wacom_remove().

Fixes: fd2a9b29dc9c ("HID: wacom: Remove AES power_supply after extended inactivity")
Signed-off-by: Thomas Zeitlhofer <thomas.zeitlhofer+lkml@ze-it.at>
Acked-by: Ping Cheng <ping.cheng@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>

authored by

Thomas Zeitlhofer and committed by
Jiri Kosina
f3054152 5cdb49a6

+1
+1
drivers/hid/wacom_sys.c
··· 2905 2905 hid_hw_stop(hdev); 2906 2906 2907 2907 cancel_delayed_work_sync(&wacom->init_work); 2908 + cancel_delayed_work_sync(&wacom->aes_battery_work); 2908 2909 cancel_work_sync(&wacom->wireless_work); 2909 2910 cancel_work_sync(&wacom->battery_work); 2910 2911 cancel_work_sync(&wacom->remote_work);