Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

md/bitmap: remove confusing code from filemap_get_page.

file_page_index(store, 0) is *always* 0.
This is because the bitmap sb, at 256 bytes, is *always* less than
one page.
So subtracting it has no effect and the code should be removed.

Reported-by: Goldwyn Rodrigues <rgoldwyn@suse.de>
Signed-off-by: NeilBrown <neilb@suse.de>

NeilBrown f2e06c58 cf170f3f

+1 -5
+1 -5
drivers/md/bitmap.c
··· 669 669 /* 670 670 * return a pointer to the page in the filemap that contains the given bit 671 671 * 672 - * this lookup is complicated by the fact that the bitmap sb might be exactly 673 - * 1 page (e.g., x86) or less than 1 page -- so the bitmap might start on page 674 - * 0 or page 1 675 672 */ 676 673 static inline struct page *filemap_get_page(struct bitmap_storage *store, 677 674 unsigned long chunk) 678 675 { 679 676 if (file_page_index(store, chunk) >= store->file_pages) 680 677 return NULL; 681 - return store->filemap[file_page_index(store, chunk) 682 - - file_page_index(store, 0)]; 678 + return store->filemap[file_page_index(store, chunk)]; 683 679 } 684 680 685 681 static int bitmap_storage_alloc(struct bitmap_storage *store,