Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: typec: stusb160x: fix return value check in stusb160x_probe()

In case of error, the function device_get_named_child_node() returns
NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210308094839.3586773-1-weiyongjun1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Wei Yongjun and committed by
Greg Kroah-Hartman
f2d90e07 604c7589

+2 -2
+2 -2
drivers/usb/typec/stusb160x.c
··· 682 682 } 683 683 684 684 fwnode = device_get_named_child_node(chip->dev, "connector"); 685 - if (IS_ERR(fwnode)) 686 - return PTR_ERR(fwnode); 685 + if (!fwnode) 686 + return -ENODEV; 687 687 688 688 /* 689 689 * When both VDD and VSYS power supplies are present, the low power