Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

video: fbdev: vt8623fb: Error out if 'pixclock' equals zero

The userspace program could pass any values to the driver through
ioctl() interface. If the driver doesn't check the value of 'pixclock',
it may cause divide error.

Fix this by checking whether 'pixclock' is zero in the function
vt8623fb_check_var().

The following log reveals it:
divide error: 0000 [#1] PREEMPT SMP KASAN PTI
RIP: 0010:vt8623fb_set_par+0xecd/0x2210
Call Trace:
<TASK>
fb_set_var+0x604/0xeb0
do_fb_ioctl+0x234/0x670
fb_ioctl+0xdd/0x130
do_syscall_64+0x3b/0x90

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>

authored by

Zheyu Ma and committed by
Helge Deller
f2bfd792 213e2df4

+3
+3
drivers/video/fbdev/vt8623fb.c
··· 321 321 { 322 322 int rv, mem, step; 323 323 324 + if (!var->pixclock) 325 + return -EINVAL; 326 + 324 327 /* Find appropriate format */ 325 328 rv = svga_match_format (vt8623fb_formats, var, NULL); 326 329 if (rv < 0)