Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: vchiq_arm: Make vchiq_shutdown never fail

Most of the users of vchiq_shutdown ignore the return value,
which is bad because this could lead to resource leaks.
So instead of changing all calls to vchiq_shutdown, it's easier
to make vchiq_shutdown never fail.

Fixes: 71bad7f08641 ("staging: add bcm2708 vchiq driver")
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Link: https://lore.kernel.org/r/20250715161108.3411-4-wahrenst@gmx.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Stefan Wahren and committed by
Greg Kroah-Hartman
f2b8ebfb 228af5a5

+1 -2
+1 -2
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
··· 393 393 struct vchiq_state *state = instance->state; 394 394 int ret = 0; 395 395 396 - if (mutex_lock_killable(&state->mutex)) 397 - return -EAGAIN; 396 + mutex_lock(&state->mutex); 398 397 399 398 /* Remove all services */ 400 399 vchiq_shutdown_internal(state, instance);