Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mfd: twl6040: Fix error return code

Convert a zero return value on error to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

authored by

Julia Lawall and committed by
Lee Jones
f2b86781 6052d83e

+1
+1
drivers/mfd/twl6040.c
··· 679 679 if (twl6040->rev < 0) { 680 680 dev_err(&client->dev, "Failed to read revision register: %d\n", 681 681 twl6040->rev); 682 + ret = twl6040->rev; 682 683 goto gpio_err; 683 684 } 684 685