Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

wifi: rtlwifi: rtl8192du: Initialise value32 in _rtl92du_init_queue_reserved_page

GCC complains:

In file included from include/linux/ieee80211.h:21,
from include/net/mac80211.h:20,
from drivers/net/wireless/realtek/rtlwifi/rtl8192du/../wifi.h:14,
from drivers/net/wireless/realtek/rtlwifi/rtl8192du/hw.c:4:
In function 'u32p_replace_bits',
inlined from '_rtl92du_init_queue_reserved_page.isra' at drivers/net/wireless/realtek/rtlwifi/rtl8192du/hw.c:225:2:
>> include/linux/bitfield.h:189:18: warning: 'value32' is used uninitialized [-Wuninitialized]

Part of the variable is indeed left uninitialised.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202408062100.DWhN0CYH-lkp@intel.com/
Fixes: e769c67105d3 ("wifi: rtlwifi: Add rtl8192du/hw.{c,h}")
Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/2a808244-93d0-492c-b304-ae1974df5df9@gmail.com

authored by

Bitterblue Smith and committed by
Kalle Valo
f1cb9d5a de9c2c66

+1 -1
+1 -1
drivers/net/wireless/realtek/rtlwifi/rtl8192du/hw.c
··· 181 181 struct rtl_hal *rtlhal = rtl_hal(rtlpriv); 182 182 u32 txqpagenum, txqpageunit; 183 183 u32 txqremainingpage; 184 + u32 value32 = 0; 184 185 u32 numhq = 0; 185 186 u32 numlq = 0; 186 187 u32 numnq = 0; 187 188 u32 numpubq; 188 - u32 value32; 189 189 190 190 if (rtlhal->macphymode != SINGLEMAC_SINGLEPHY) { 191 191 numpubq = NORMAL_PAGE_NUM_PUBQ_92D_DUAL_MAC;