Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

virtio-blk: fixup coccinelle warnings

coccicheck complains about the use of snprintf() in sysfs show
functions:
WARNING use scnprintf or sprintf

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
Link: https://lore.kernel.org/r/20211021065111.1047824-1-ye.guojin@zte.com.cn
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

authored by

Ye Guojin and committed by
Michael S. Tsirkin
f1aa12f5 ef5c366f

+1 -1
+1 -1
drivers/block/virtio_blk.c
··· 704 704 u8 writeback = virtblk_get_cache_mode(vblk->vdev); 705 705 706 706 BUG_ON(writeback >= ARRAY_SIZE(virtblk_cache_types)); 707 - return snprintf(buf, 40, "%s\n", virtblk_cache_types[writeback]); 707 + return sysfs_emit(buf, "%s\n", virtblk_cache_types[writeback]); 708 708 } 709 709 710 710 static DEVICE_ATTR_RW(cache_type);