Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ethernet/intel: Use setup_timer

Use the timer API function setup_timer instead of structure field
assignments to initialize a timer.

A simplified version of the Coccinelle semantic patch that performs
this transformation is as follows:

@change@
expression e1, e2, e3, e4, a, b;
@@

-init_timer(&e1);
+setup_timer(&e1, a, b);

... when != a = e2
when != b = e3

-e1.function = a;
... when != b = e4
-e1.data = b;

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Vaishali Thakkar and committed by
David S. Miller
f16e9d86 3324b584

+1 -3
+1 -3
drivers/net/ethernet/intel/e100.c
··· 2922 2922 2923 2923 pci_set_master(pdev); 2924 2924 2925 - init_timer(&nic->watchdog); 2926 - nic->watchdog.function = e100_watchdog; 2927 - nic->watchdog.data = (unsigned long)nic; 2925 + setup_timer(&nic->watchdog, e100_watchdog, (unsigned long)nic); 2928 2926 2929 2927 INIT_WORK(&nic->tx_timeout_task, e100_tx_timeout_task); 2930 2928