drm/msm: clean up fault injection usage

With the proper stubs in place in linux/fault-inject.h, we can remove a
bunch of conditional compilation for CONFIG_FAULT_INJECTION=n.

Link: https://lkml.kernel.org/r/[e-mail]
Signed-off-by: Jani Nikula <[e-mail]>
Reviewed-by: Thomas Hellström <[e-mail]>
Reviewed-by: Himal Prasad Ghimiray <[e-mail]>
Reviewed-by: Abhinav Kumar <[e-mail]>
Cc: Akinobu Mita <[e-mail]>
Cc: Rob Clark <[e-mail]>
Cc: Dmitry Baryshkov <[e-mail]>
Cc: Lucas De Marchi <[e-mail]>
Cc: Rodrigo Vivi <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>

drivers/gpu/drm/msm/msm_debugfs.c

···
 	if (priv->kms && priv->kms->funcs->debugfs_init)
 		priv->kms->funcs->debugfs_init(priv->kms, minor);
 
-#ifdef CONFIG_FAULT_INJECTION
 	fault_create_debugfs_attr("fail_gem_alloc", minor->debugfs_root,
 				  &fail_gem_alloc);
 	fault_create_debugfs_attr("fail_gem_iova", minor->debugfs_root,
 				  &fail_gem_iova);
-#endif
 }
 #endif
 

drivers/gpu/drm/msm/msm_drv.c

···
 MODULE_PARM_DESC(modeset, "Use kernel modesetting [KMS] (1=on (default), 0=disable)");
 module_param(modeset, bool, 0600);
 
-#ifdef CONFIG_FAULT_INJECTION
 DECLARE_FAULT_ATTR(fail_gem_alloc);
 DECLARE_FAULT_ATTR(fail_gem_iova);
-#endif
 
 static int msm_drm_uninit(struct device *dev)
 {

drivers/gpu/drm/msm/msm_drv.h

···
 #include <drm/msm_drm.h>
 #include <drm/drm_gem.h>
 
-#ifdef CONFIG_FAULT_INJECTION
 extern struct fault_attr fail_gem_alloc;
 extern struct fault_attr fail_gem_iova;
-#else
-#  define should_fail(attr, size) 0
-#endif
 
 struct msm_kms;
 struct msm_gpu;