Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: caif: Fix a sleep-in-atomic bug in cfpkt_create_pfx

The kernel may sleep under a rcu read lock in cfpkt_create_pfx, and the
function call path is:
cfcnfg_linkup_rsp (acquire the lock by rcu_read_lock)
cfctrl_linkdown_req
cfpkt_create
cfpkt_create_pfx
alloc_skb(GFP_KERNEL) --> may sleep
cfserl_receive (acquire the lock by rcu_read_lock)
cfpkt_split
cfpkt_create_pfx
alloc_skb(GFP_KERNEL) --> may sleep

There is "in_interrupt" in cfpkt_create_pfx to decide use "GFP_KERNEL" or
"GFP_ATOMIC". In this situation, "GFP_KERNEL" is used because the function
is called under a rcu read lock, instead in interrupt.

To fix it, only "GFP_ATOMIC" is used in cfpkt_create_pfx.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Jia-Ju Bai and committed by
David S. Miller
f146e872 5aa32f53

+1 -5
+1 -5
net/caif/cfpkt_skbuff.c
··· 81 81 { 82 82 struct sk_buff *skb; 83 83 84 - if (likely(in_interrupt())) 85 - skb = alloc_skb(len + pfx, GFP_ATOMIC); 86 - else 87 - skb = alloc_skb(len + pfx, GFP_KERNEL); 88 - 84 + skb = alloc_skb(len + pfx, GFP_ATOMIC); 89 85 if (unlikely(skb == NULL)) 90 86 return NULL; 91 87