Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

x86, apic: Remove early_init_lapic_mapping()

It is almost the same as smp_register_lapic_addr(). We just need to
let smp_read_mpc() call smp_register_lapic_addr() when early==1.

Add the apic_printk to smp_register_lapic_address()

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
LKML-Reference: <4CFDF681.3030509@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

authored by

Yinghai Lu and committed by
Thomas Gleixner
f1157141 c0104d38

+5 -31
-1
arch/x86/include/asm/apic.h
··· 245 245 * On 32bit this is mach-xxx local 246 246 */ 247 247 #ifdef CONFIG_X86_64 248 - extern void early_init_lapic_mapping(void); 249 248 extern int apic_is_clustered_box(void); 250 249 #else 251 250 static inline int apic_is_clustered_box(void)
+2 -22
arch/x86/kernel/apic/apic.c
··· 1630 1630 } 1631 1631 #endif 1632 1632 1633 - #ifdef CONFIG_X86_64 1634 - void __init early_init_lapic_mapping(void) 1635 - { 1636 - /* 1637 - * If no local APIC can be found then go out 1638 - * : it means there is no mpatable and MADT 1639 - */ 1640 - if (!smp_found_config) 1641 - return; 1642 - 1643 - set_fixmap_nocache(FIX_APIC_BASE, mp_lapic_addr); 1644 - apic_printk(APIC_VERBOSE, "mapped APIC to %16lx (%16lx)\n", 1645 - APIC_BASE, mp_lapic_addr); 1646 - 1647 - /* 1648 - * Fetch the APIC ID of the BSP in case we have a 1649 - * default configuration (or the MP table is broken). 1650 - */ 1651 - boot_cpu_physical_apicid = read_apic_id(); 1652 - } 1653 - #endif 1654 - 1655 1633 /** 1656 1634 * init_apic_mappings - initialize APIC mappings 1657 1635 */ ··· 1685 1707 mp_lapic_addr = address; 1686 1708 1687 1709 set_fixmap_nocache(FIX_APIC_BASE, address); 1710 + apic_printk(APIC_VERBOSE, "mapped APIC to %16lx (%16lx)\n", 1711 + APIC_BASE, mp_lapic_addr); 1688 1712 if (boot_cpu_physical_apicid == -1U) { 1689 1713 boot_cpu_physical_apicid = read_apic_id(); 1690 1714 apic_version[boot_cpu_physical_apicid] =
+3 -7
arch/x86/kernel/mpparse.c
··· 289 289 #ifdef CONFIG_X86_32 290 290 generic_mps_oem_check(mpc, oem, str); 291 291 #endif 292 - /* save the local APIC address, it might be non-default */ 293 - if (!acpi_lapic) 294 - mp_lapic_addr = mpc->lapic; 295 - 296 - if (early) 297 - return 1; 298 - 299 292 /* Initialize the lapic mapping */ 300 293 if (!acpi_lapic) 301 294 register_lapic_address(mpc->lapic); 295 + 296 + if (early) 297 + return 1; 302 298 303 299 if (mpc->oemptr) 304 300 x86_init.mpparse.smp_read_mpc_oem(mpc);
-1
arch/x86/mm/amdtopology_64.c
··· 66 66 if (smp_found_config) 67 67 early_get_smp_config(); 68 68 #endif 69 - early_init_lapic_mapping(); 70 69 } 71 70 72 71 int __init amd_get_nodes(struct bootnode *physnodes)