Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[SCSI] tgt: convert to use the data buffer accessors

- convert to use the new accessors for the sg lists and the
parameters.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

authored by

FUJITA Tomonori and committed by
James Bottomley
f10ab66f 1237c98d

+20 -18
+1 -1
drivers/scsi/ibmvscsi/ibmvstgt.c
··· 292 292 dprintk("%p %p %x %u\n", iue, target, vio_iu(iue)->srp.cmd.cdb[0], 293 293 cmd->usg_sg); 294 294 295 - if (sc->use_sg) 295 + if (scsi_sg_count(sc)) 296 296 err = srp_transfer_data(sc, &vio_iu(iue)->srp.cmd, ibmvstgt_rdma, 1, 1); 297 297 298 298 spin_lock_irqsave(&target->lock, flags);
+12 -11
drivers/scsi/libsrp.c
··· 192 192 193 193 if (dma_map) { 194 194 iue = (struct iu_entry *) sc->SCp.ptr; 195 - sg = sc->request_buffer; 195 + sg = scsi_sglist(sc); 196 196 197 - dprintk("%p %u %u %d\n", iue, sc->request_bufflen, 198 - md->len, sc->use_sg); 197 + dprintk("%p %u %u %d\n", iue, scsi_bufflen(sc), 198 + md->len, scsi_sg_count(sc)); 199 199 200 - nsg = dma_map_sg(iue->target->dev, sg, sc->use_sg, 200 + nsg = dma_map_sg(iue->target->dev, sg, scsi_sg_count(sc), 201 201 DMA_BIDIRECTIONAL); 202 202 if (!nsg) { 203 - printk("fail to map %p %d\n", iue, sc->use_sg); 203 + printk("fail to map %p %d\n", iue, scsi_sg_count(sc)); 204 204 return 0; 205 205 } 206 - len = min(sc->request_bufflen, md->len); 206 + len = min(scsi_bufflen(sc), md->len); 207 207 } else 208 208 len = md->len; 209 209 ··· 229 229 230 230 if (dma_map || ext_desc) { 231 231 iue = (struct iu_entry *) sc->SCp.ptr; 232 - sg = sc->request_buffer; 232 + sg = scsi_sglist(sc); 233 233 234 234 dprintk("%p %u %u %d %d\n", 235 - iue, sc->request_bufflen, id->len, 235 + iue, scsi_bufflen(sc), id->len, 236 236 cmd->data_in_desc_cnt, cmd->data_out_desc_cnt); 237 237 } 238 238 ··· 268 268 269 269 rdma: 270 270 if (dma_map) { 271 - nsg = dma_map_sg(iue->target->dev, sg, sc->use_sg, DMA_BIDIRECTIONAL); 271 + nsg = dma_map_sg(iue->target->dev, sg, scsi_sg_count(sc), 272 + DMA_BIDIRECTIONAL); 272 273 if (!nsg) { 273 - eprintk("fail to map %p %d\n", iue, sc->use_sg); 274 + eprintk("fail to map %p %d\n", iue, scsi_sg_count(sc)); 274 275 err = -EIO; 275 276 goto free_mem; 276 277 } 277 - len = min(sc->request_bufflen, id->len); 278 + len = min(scsi_bufflen(sc), id->len); 278 279 } else 279 280 len = id->len; 280 281
+1 -1
drivers/scsi/scsi_tgt_if.c
··· 112 112 memset(&ev, 0, sizeof(ev)); 113 113 ev.p.cmd_req.host_no = shost->host_no; 114 114 ev.p.cmd_req.itn_id = itn_id; 115 - ev.p.cmd_req.data_len = cmd->request_bufflen; 115 + ev.p.cmd_req.data_len = scsi_bufflen(cmd); 116 116 memcpy(ev.p.cmd_req.scb, cmd->cmnd, sizeof(ev.p.cmd_req.scb)); 117 117 memcpy(ev.p.cmd_req.lun, lun, sizeof(ev.p.cmd_req.lun)); 118 118 ev.p.cmd_req.attribute = cmd->tag;
+6 -5
drivers/scsi/scsi_tgt_lib.c
··· 331 331 332 332 scsi_tgt_uspace_send_status(cmd, tcmd->itn_id, tcmd->tag); 333 333 334 - if (cmd->request_buffer) 334 + if (scsi_sglist(cmd)) 335 335 scsi_free_sgtable(cmd); 336 336 337 337 queue_work(scsi_tgtd, &tcmd->work); ··· 365 365 366 366 cmd->request_bufflen = rq->data_len; 367 367 368 - dprintk("cmd %p cnt %d %lu\n", cmd, cmd->use_sg, rq_data_dir(rq)); 369 - count = blk_rq_map_sg(rq->q, rq, cmd->request_buffer); 370 - if (likely(count <= cmd->use_sg)) { 368 + dprintk("cmd %p cnt %d %lu\n", cmd, scsi_sg_count(cmd), 369 + rq_data_dir(rq)); 370 + count = blk_rq_map_sg(rq->q, rq, scsi_sglist(cmd)); 371 + if (likely(count <= scsi_sg_count(cmd))) { 371 372 cmd->use_sg = count; 372 373 return 0; 373 374 } 374 375 375 - eprintk("cmd %p cnt %d\n", cmd, cmd->use_sg); 376 + eprintk("cmd %p cnt %d\n", cmd, scsi_sg_count(cmd)); 376 377 scsi_free_sgtable(cmd); 377 378 return -EINVAL; 378 379 }