usb: atm: use request_firmware_direct() for firmware probing
When disconnecting a device while firmware is not present on the system, usbatm_usb_disconnect() waits for the heavy_init thread to finish: wait_for_completion(&instance->thread_exited); If CONFIG_FW_LOADER_USER_HELPER_FALLBACK is enabled, missing firmware causes request_firmware() to fall back to sysfs/udevd. This creates a circular dependency during disconnect: 1. usb_disconnect() holds device_lock(&udev->dev). 2. usbatm_usb_disconnect() waits for instance->thread to exit. 3. instance->thread waits for request_firmware() sysfs fallback. 4. udevd receives the firmware uevent and attempts to read sysfs attributes (e.g. serial), blocking on device_lock(&udev->dev). Furthermore, the fallback wait uses wait_for_completion_killable_timeout(), which ignores the non-fatal SIGTERM signal sent by usbatm_usb_disconnect(). Because speedtch and cxacru probe multiple candidate firmware files sequentially, each file stalls for the 60-second fallback timeout, triggering hung task timeouts (>120s) reported by syzbot. Switch to request_firmware_direct() to probe firmware files directly from the filesystem without falling back to user-mode helper. Cc: stable+noautosel@kernel.org # untested fix to a driver init path race Reported-by: syzbot+9ca2c9f85bd8b5e46516@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=9ca2c9f85bd8b5e46516 Signed-off-by: Matvey Valigura <valigurasm@gmail.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20260924050654.15347-1-valigurasm@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>