Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/tests: modes: Fix drm_display_mode memory leak

drm_analog_tv_mode() and its variants return a drm_display_mode that
needs to be destroyed later one. The
drm_test_modes_analog_tv_mono_576i() test never does however, which
leads to a memory leak.

Let's make sure it's freed.

Reported-by: Philipp Stanner <phasta@mailbox.org>
Closes: https://lore.kernel.org/dri-devel/a7655158a6367ac46194d57f4b7433ef0772a73e.camel@mailbox.org/
Fixes: e31538489908 ("drm/tests: Add tests for the new Monochrome value of tv_mode")
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20250408-drm-kunit-drm-display-mode-memleak-v1-6-996305a2e75a@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>

+4
+4
drivers/gpu/drm/tests/drm_modes_test.c
··· 156 156 { 157 157 struct drm_test_modes_priv *priv = test->priv; 158 158 struct drm_display_mode *mode; 159 + int ret; 159 160 160 161 mode = drm_analog_tv_mode(priv->drm, 161 162 DRM_MODE_TV_MODE_MONOCHROME, 162 163 13500 * HZ_PER_KHZ, 720, 576, 163 164 true); 164 165 KUNIT_ASSERT_NOT_NULL(test, mode); 166 + 167 + ret = drm_kunit_add_mode_destroy_action(test, mode); 168 + KUNIT_ASSERT_EQ(test, ret, 0); 165 169 166 170 KUNIT_EXPECT_EQ(test, drm_mode_vrefresh(mode), 50); 167 171 KUNIT_EXPECT_EQ(test, mode->hdisplay, 720);