Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ia64, salinfo: Fix hotplug callback registration

Subsystems that want to register CPU hotplug callbacks, as well as perform
initialization for the CPUs that are already online, often do it as shown
below:

get_online_cpus();

for_each_online_cpu(cpu)
init_cpu(cpu);

register_cpu_notifier(&foobar_cpu_notifier);

put_online_cpus();

This is wrong, since it is prone to ABBA deadlocks involving the
cpu_add_remove_lock and the cpu_hotplug.lock (when running concurrently
with CPU hotplug operations).

Instead, the correct and race-free way of performing the callback
registration is:

cpu_notifier_register_begin();

for_each_online_cpu(cpu)
init_cpu(cpu);

/* Note the use of the double underscored version of the API */
__register_cpu_notifier(&foobar_cpu_notifier);

cpu_notifier_register_done();

Fix the salinfo code in ia64 by using this latter form of callback
registration.

Cc: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

authored by

Srivatsa S. Bhat and committed by
Rafael J. Wysocki
eff722b0 f0bdb5e0

+5 -1
+5 -1
arch/ia64/kernel/salinfo.c
··· 635 635 (void *)salinfo_entries[i].feature); 636 636 } 637 637 638 + cpu_notifier_register_begin(); 639 + 638 640 for (i = 0; i < ARRAY_SIZE(salinfo_log_name); i++) { 639 641 data = salinfo_data + i; 640 642 data->type = i; ··· 671 669 salinfo_timer.function = &salinfo_timeout; 672 670 add_timer(&salinfo_timer); 673 671 674 - register_hotcpu_notifier(&salinfo_cpu_notifier); 672 + __register_hotcpu_notifier(&salinfo_cpu_notifier); 673 + 674 + cpu_notifier_register_done(); 675 675 676 676 return 0; 677 677 }