Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

cdc-acm: cleaning up debug in data submission path

Further cleanup making the debug messages more precise, useful
and removing mere trace points.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Oliver Neukum and committed by
Greg Kroah-Hartman
efbe27b3 46e75075

+6 -10
+6 -10
drivers/usb/class/cdc-acm.c
··· 415 415 unsigned long flags; 416 416 int status = urb->status; 417 417 418 - dev_vdbg(&acm->data->dev, "%s - urb %d, len %d\n", __func__, 419 - rb->index, urb->actual_length); 418 + dev_vdbg(&acm->data->dev, "got urb %d, len %d, status %d\n", 419 + rb->index, urb->actual_length, 420 + status); 420 421 421 422 if (!acm->dev) { 422 423 set_bit(rb->index, &acm->read_urbs_free); ··· 427 426 428 427 if (status) { 429 428 set_bit(rb->index, &acm->read_urbs_free); 430 - dev_dbg(&acm->data->dev, "%s - non-zero urb status: %d\n", 431 - __func__, status); 432 429 if ((status != -ENOENT) || (urb->actual_length == 0)) 433 430 return; 434 431 } ··· 461 462 int status = urb->status; 462 463 463 464 if (status || (urb->actual_length != urb->transfer_buffer_length)) 464 - dev_vdbg(&acm->data->dev, "%s - len %d/%d, status %d\n", 465 - __func__, 465 + dev_vdbg(&acm->data->dev, "wrote len %d/%d, status %d\n", 466 466 urb->actual_length, 467 467 urb->transfer_buffer_length, 468 468 status); ··· 475 477 static void acm_softint(struct work_struct *work) 476 478 { 477 479 struct acm *acm = container_of(work, struct acm, work); 478 - 479 - dev_vdbg(&acm->data->dev, "%s\n", __func__); 480 480 481 481 tty_port_tty_wakeup(&acm->port); 482 482 } ··· 670 674 if (!count) 671 675 return 0; 672 676 673 - dev_vdbg(&acm->data->dev, "%s - count %d\n", __func__, count); 677 + dev_vdbg(&acm->data->dev, "%d bytes from tty layer\n", count); 674 678 675 679 spin_lock_irqsave(&acm->write_lock, flags); 676 680 wbn = acm_wb_alloc(acm); ··· 687 691 } 688 692 689 693 count = (count > acm->writesize) ? acm->writesize : count; 690 - dev_vdbg(&acm->data->dev, "%s - write %d\n", __func__, count); 694 + dev_vdbg(&acm->data->dev, "writing %d bytes\n", count); 691 695 memcpy(wb->buf, buf, count); 692 696 wb->len = count; 693 697