Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: ldusb: replace ternary operator with max_t()

Fix the following coccicheck warning:

drivers/usb/misc/ldusb.c:719: WARNING opportunity for max().
drivers/usb/misc/ldusb.c:721: WARNING opportunity for max().

max_t() macro is defined in include/linux/minmax.h. It avoids
multiple evaluations of the arguments when non-constant and performs
strict type-checking.

Signed-off-by: Jiangshan Yi <yijiangshan@kylinos.cn>
Link: https://lore.kernel.org/r/20220713070205.3047256-1-13667453960@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Jiangshan Yi and committed by
Greg Kroah-Hartman
efa2bebf 5e76ee96

+4 -2
+4 -2
drivers/usb/misc/ldusb.c
··· 716 716 dev->interrupt_out_urb = usb_alloc_urb(0, GFP_KERNEL); 717 717 if (!dev->interrupt_out_urb) 718 718 goto error; 719 - dev->interrupt_in_interval = min_interrupt_in_interval > dev->interrupt_in_endpoint->bInterval ? min_interrupt_in_interval : dev->interrupt_in_endpoint->bInterval; 719 + dev->interrupt_in_interval = max_t(int, min_interrupt_in_interval, 720 + dev->interrupt_in_endpoint->bInterval); 720 721 if (dev->interrupt_out_endpoint) 721 - dev->interrupt_out_interval = min_interrupt_out_interval > dev->interrupt_out_endpoint->bInterval ? min_interrupt_out_interval : dev->interrupt_out_endpoint->bInterval; 722 + dev->interrupt_out_interval = max_t(int, min_interrupt_out_interval, 723 + dev->interrupt_out_endpoint->bInterval); 722 724 723 725 /* we can register the device now, as it is ready */ 724 726 usb_set_intfdata(intf, dev);