Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tty: Fix comments that reference BKL, eventd, old paths

Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Kevin Cernekee and committed by
Greg Kroah-Hartman
ef4f527c a205a56d

+10 -10
+9 -9
drivers/tty/serial/serial_core.c
··· 1309 1309 } 1310 1310 1311 1311 /* 1312 - * In 2.4.5, calls to this will be serialized via the BKL in 1313 - * linux/drivers/char/tty_io.c:tty_release() 1314 - * linux/drivers/char/tty_io.c:do_tty_handup() 1312 + * Calls to uart_close() are serialised via the tty_lock in 1313 + * drivers/tty/tty_io.c:tty_release() 1314 + * drivers/tty/tty_io.c:do_tty_hangup() 1315 + * This runs from a workqueue and can sleep for a _short_ time only. 1315 1316 */ 1316 1317 static void uart_close(struct tty_struct *tty, struct file *filp) 1317 1318 { ··· 1439 1438 } 1440 1439 1441 1440 /* 1442 - * This is called with the BKL held in 1443 - * linux/drivers/char/tty_io.c:do_tty_hangup() 1444 - * We're called from the eventd thread, so we can sleep for 1445 - * a _short_ time only. 1441 + * Calls to uart_hangup() are serialised by the tty_lock in 1442 + * drivers/tty/tty_io.c:do_tty_hangup() 1443 + * This runs from a workqueue and can sleep for a _short_ time only. 1446 1444 */ 1447 1445 static void uart_hangup(struct tty_struct *tty) 1448 1446 { ··· 1522 1522 } 1523 1523 1524 1524 /* 1525 - * calls to uart_open are serialised by the BKL in 1526 - * fs/char_dev.c:chrdev_open() 1525 + * Calls to uart_open are serialised by the tty_lock in 1526 + * drivers/tty/tty_io.c:tty_open() 1527 1527 * Note that if this fails, then uart_close() _will_ be called. 1528 1528 * 1529 1529 * In time, we want to scrap the "opening nonpresent ports"
+1 -1
drivers/tty/tty_io.c
··· 536 536 * __tty_hangup - actual handler for hangup events 537 537 * @work: tty device 538 538 * 539 - * This can be called by the "eventd" kernel thread. That is process 539 + * This can be called by a "kworker" kernel thread. That is process 540 540 * synchronous but doesn't hold any locks, so we need to make sure we 541 541 * have the appropriate locks for what we're doing. 542 542 *