Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

kernfs: checking for IS_ERR() instead of NULL

The kernfs_get_inode() returns NULL on error, it never returns error
pointers.

Fixes: aa8188253474 ("kernfs: add exportfs operations")
Acked-by: Tejun Heo <tj@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

Dan Carpenter and committed by
Jens Axboe
ef13ecbc 974c5856

+2 -2
+2 -2
fs/kernfs/mount.c
··· 99 99 return ERR_PTR(-ESTALE); 100 100 inode = kernfs_get_inode(sb, kn); 101 101 kernfs_put(kn); 102 - if (IS_ERR(inode)) 103 - return ERR_CAST(inode); 102 + if (!inode) 103 + return ERR_PTR(-ESTALE); 104 104 105 105 if (generation && inode->i_generation != generation) { 106 106 /* we didn't find the right inode.. */