Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers/net/cs89x0.c: Avoid using magic number in set_dma_mode

The constant DMA_RX_MODE is defined to be 0x14 in the local include file
cs89x0.h. Since a constant with the same name is used elsewhere with
set_dma_mode, it seems likely that this constant could be used here.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E1; identifier I; constant int C; @@
(
set_dma_mode(E1,I,...)
|
*set_dma_mode(E1,C,...)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Julia Lawall and committed by
David S. Miller
ef0657c4 5dcc60b7

+1 -1
+1 -1
drivers/net/cs89x0.c
··· 1367 1367 spin_lock_irqsave(&lp->lock, flags); 1368 1368 disable_dma(dev->dma); 1369 1369 clear_dma_ff(dev->dma); 1370 - set_dma_mode(dev->dma, 0x14); /* auto_init as well */ 1370 + set_dma_mode(dev->dma, DMA_RX_MODE); /* auto_init as well */ 1371 1371 set_dma_addr(dev->dma, isa_virt_to_bus(lp->dma_buff)); 1372 1372 set_dma_count(dev->dma, lp->dmasize*1024); 1373 1373 enable_dma(dev->dma);