Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

V4L/DVB (12131): BUGFIX: An incorrect Carrier Recovery Loop optimization table was being

loaded for a given chip version. This would cause the optimization in
tuning not to be applied and thus a failed expectation, in tuning speed
increment. The patch swaps the tables in use. It also fixes a possible
one in a million condition where state->dev_ver implies an older Cut
(Cut < 2.0, eventhough the driver doesn't attach to any Cut older than
2.0) or even negative (due to a bad I2C bus master driver) for the card
combination.

Thanks to Mauro Carvalho Chehab <mchehab@infradead.org> for pointing
out the issue at large.

Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

authored by

Manu Abraham and committed by
Mauro Carvalho Chehab
eebf8d86 0a5ded56

+6 -3
+6 -3
drivers/media/dvb/frontends/stv090x.c
··· 2694 2694 break; 2695 2695 } 2696 2696 2697 - if (state->dev_ver >= 0x30) 2698 - short_crl = stv090x_s2_short_crl_cut20; 2699 - else if (state->dev_ver >= 0x20) 2697 + if (state->dev_ver >= 0x30) { 2698 + /* Cut 3.0 and up */ 2700 2699 short_crl = stv090x_s2_short_crl_cut30; 2700 + } else { 2701 + /* Cut 2.0 and up: we don't support cuts older than 2.0 */ 2702 + short_crl = stv090x_s2_short_crl_cut20; 2703 + } 2701 2704 2702 2705 if (state->srate <= 3000000) 2703 2706 aclc = short_crl[index].crl_2;