Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panel: innolux-p079zca: Don't call unprepare+disable at shutdown/remove

It's the responsibility of a correctly written DRM modeset driver to
call drm_atomic_helper_shutdown() at shutdown time and that should be
disabling / unpreparing the panel if needed. Panel drivers shouldn't
be calling these functions themselves.

A recent effort was made to fix as many DRM modeset drivers as
possible [1] [2] [3] and most drivers are fixed now.

A grep through mainline for compatible strings used by this driver
indicates that it is used by Rockchip boards. The Rockchip driver
appears to be correctly calling drm_atomic_helper_shutdown() so we can
remove the calls.

[1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org
[2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org
[3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org

Cc: Chris Zhong <zyw@rock-chips.com>
Cc: Lin Huang <hl@rock-chips.com>
Cc: Brian Norris <briannorris@chromium.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240503143327.RFT.v2.9.Iaddb8e0cab570e2f8066a4baf1d49239a820b799@changeid

-16
-16
drivers/gpu/drm/panel/panel-innolux-p079zca.c
··· 460 460 struct innolux_panel *innolux = mipi_dsi_get_drvdata(dsi); 461 461 int err; 462 462 463 - err = drm_panel_unprepare(&innolux->base); 464 - if (err < 0) 465 - dev_err(&dsi->dev, "failed to unprepare panel: %d\n", err); 466 - 467 - err = drm_panel_disable(&innolux->base); 468 - if (err < 0) 469 - dev_err(&dsi->dev, "failed to disable panel: %d\n", err); 470 463 471 464 err = mipi_dsi_detach(dsi); 472 465 if (err < 0) 473 466 dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err); 474 467 475 468 innolux_panel_del(innolux); 476 - } 477 - 478 - static void innolux_panel_shutdown(struct mipi_dsi_device *dsi) 479 - { 480 - struct innolux_panel *innolux = mipi_dsi_get_drvdata(dsi); 481 - 482 - drm_panel_unprepare(&innolux->base); 483 - drm_panel_disable(&innolux->base); 484 469 } 485 470 486 471 static struct mipi_dsi_driver innolux_panel_driver = { ··· 475 490 }, 476 491 .probe = innolux_panel_probe, 477 492 .remove = innolux_panel_remove, 478 - .shutdown = innolux_panel_shutdown, 479 493 }; 480 494 module_mipi_dsi_driver(innolux_panel_driver); 481 495