Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] drivers/media/video: add missing kfree

Free the recently allocated qcam in each case.

The semantic match that finds this problem is as follows:

// <smpl>
@r@
identifier x;
@@

kfree(x)

@@
identifier r.x;
expression E1!=0,E2,E3,E4;
statement S;
@@

(
if (<+...x...+>) S
|
if (...) { ... when != kfree(x)
when != if (...) { ... kfree(x); ... }
when != x = E3
* return E1;
}
... when != x = E2
if (...) { ... when != x = E4
kfree(x); ... return ...; }
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

authored by

Julia Lawall and committed by
Mauro Carvalho Chehab
ee893e9a 37f9619d

+2
+1
drivers/media/video/bw-qcam.c
··· 893 893 894 894 if (v4l2_device_register(NULL, v4l2_dev) < 0) { 895 895 v4l2_err(v4l2_dev, "Could not register v4l2_device\n"); 896 + kfree(qcam); 896 897 return NULL; 897 898 } 898 899
+1
drivers/media/video/c-qcam.c
··· 750 750 751 751 if (v4l2_device_register(NULL, v4l2_dev) < 0) { 752 752 v4l2_err(v4l2_dev, "Could not register v4l2_device\n"); 753 + kfree(qcam); 753 754 return NULL; 754 755 } 755 756