Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dm pcache: fix cache info indexing

The on-media cache_info index used sizeof(struct) instead of the
4K metadata stride, so gc_percent updates from dmsetup message
were written between slots and lost after reboot. Use
PCACHE_CACHE_INFO_SIZE in get_cache_info_addr() and align
info_index with the slot returned by pcache_meta_find_latest().

Signed-off-by: Li Chen <chenl311@chinatelecom.cn>
Signed-off-by: Dongsheng Yang <dongsheng.yang@linux.dev>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Reviewed-by: Zheng Gu <cengku@gmail.com>
Cc: stable@vger.kernel.org # 6.18

authored by

Li Chen and committed by
Mikulas Patocka
ee763317 ebbb9034

+4 -1
+4 -1
drivers/md/dm-pcache/cache.c
··· 10 10 11 11 static inline struct pcache_cache_info *get_cache_info_addr(struct pcache_cache *cache) 12 12 { 13 - return cache->cache_info_addr + cache->info_index; 13 + return (struct pcache_cache_info *)((char *)cache->cache_info_addr + 14 + (size_t)cache->info_index * PCACHE_CACHE_INFO_SIZE); 14 15 } 15 16 16 17 static void cache_info_write(struct pcache_cache *cache) ··· 49 48 cache->cache_info.flags & PCACHE_CACHE_FLAGS_DATA_CRC ? "true" : "false"); 50 49 return -EINVAL; 51 50 } 51 + 52 + cache->info_index = ((char *)cache_info_addr - (char *)cache->cache_info_addr) / PCACHE_CACHE_INFO_SIZE; 52 53 53 54 return 0; 54 55 }