Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

libceph: Remove unused pagevec functions

ceph_copy_user_to_page_vector() has been unused since 2013's commit
e8344e668915 ("ceph: Implement writev/pwritev for sync operation.")

ceph_copy_to_page_vector() has been unused since 2012's commit
913d2fdcf605 ("rbd: always pass ops array to rbd_req_sync_op()")

Remove them.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

authored by

Dr. David Alan Gilbert and committed by
Ilya Dryomov
ee1eb8cc 03854920

-58
-6
include/linux/ceph/libceph.h
··· 317 317 extern void ceph_put_page_vector(struct page **pages, int num_pages, 318 318 bool dirty); 319 319 extern struct page **ceph_alloc_page_vector(int num_pages, gfp_t flags); 320 - extern int ceph_copy_user_to_page_vector(struct page **pages, 321 - const void __user *data, 322 - loff_t off, size_t len); 323 - extern void ceph_copy_to_page_vector(struct page **pages, 324 - const void *data, 325 - loff_t off, size_t len); 326 320 extern void ceph_copy_from_page_vector(struct page **pages, 327 321 void *data, 328 322 loff_t off, size_t len);
-52
net/ceph/pagevec.c
··· 55 55 } 56 56 EXPORT_SYMBOL(ceph_alloc_page_vector); 57 57 58 - /* 59 - * copy user data into a page vector 60 - */ 61 - int ceph_copy_user_to_page_vector(struct page **pages, 62 - const void __user *data, 63 - loff_t off, size_t len) 64 - { 65 - int i = 0; 66 - int po = off & ~PAGE_MASK; 67 - int left = len; 68 - int l, bad; 69 - 70 - while (left > 0) { 71 - l = min_t(int, PAGE_SIZE-po, left); 72 - bad = copy_from_user(page_address(pages[i]) + po, data, l); 73 - if (bad == l) 74 - return -EFAULT; 75 - data += l - bad; 76 - left -= l - bad; 77 - po += l - bad; 78 - if (po == PAGE_SIZE) { 79 - po = 0; 80 - i++; 81 - } 82 - } 83 - return len; 84 - } 85 - EXPORT_SYMBOL(ceph_copy_user_to_page_vector); 86 - 87 - void ceph_copy_to_page_vector(struct page **pages, 88 - const void *data, 89 - loff_t off, size_t len) 90 - { 91 - int i = 0; 92 - size_t po = off & ~PAGE_MASK; 93 - size_t left = len; 94 - 95 - while (left > 0) { 96 - size_t l = min_t(size_t, PAGE_SIZE-po, left); 97 - 98 - memcpy(page_address(pages[i]) + po, data, l); 99 - data += l; 100 - left -= l; 101 - po += l; 102 - if (po == PAGE_SIZE) { 103 - po = 0; 104 - i++; 105 - } 106 - } 107 - } 108 - EXPORT_SYMBOL(ceph_copy_to_page_vector); 109 - 110 58 void ceph_copy_from_page_vector(struct page **pages, 111 59 void *data, 112 60 loff_t off, size_t len)