Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/vmwgfx: Replace one-element array with flexible-array member

One-element arrays are deprecated, and we are replacing them with flexible
array members instead. So, replace one-element array with flexible-array
member in struct vmw_view.

This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
routines on memcpy() and help us make progress towards globally
enabling -fstrict-flex-arrays=3 [1].

This results in no differences in binary output.

Link: https://github.com/KSPP/linux/issues/79
Link: https://github.com/KSPP/linux/issues/254
Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1]
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Zack Rusin <zackr@vmware.com>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

+1 -1
+1 -1
drivers/gpu/drm/vmwgfx/vmwgfx_so.c
··· 70 70 unsigned view_id; /* Immutable */ 71 71 u32 cmd_size; /* Immutable */ 72 72 bool committed; /* Protected by binding_mutex */ 73 - u32 cmd[1]; /* Immutable */ 73 + u32 cmd[]; /* Immutable */ 74 74 }; 75 75 76 76 static int vmw_view_create(struct vmw_resource *res);