Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/i915: Convert the register access tracepoint to be conditional

The TRACE_EVENT_CONDITION is supposed to generate more efficient code
than if (cond) trace(), which is what we are currently using inside the
register access functions.

v2: Rebase onto uncore

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

authored by

Chris Wilson and committed by
Daniel Vetter
ed71f1b4 a7f31ee0

+8 -6
+1 -1
drivers/gpu/drm/i915/i915_debugfs.c
··· 1004 1004 } 1005 1005 1006 1006 gt_core_status = readl(dev_priv->regs + GEN6_GT_CORE_STATUS); 1007 - trace_i915_reg_rw(false, GEN6_GT_CORE_STATUS, gt_core_status, 4); 1007 + trace_i915_reg_rw(false, GEN6_GT_CORE_STATUS, gt_core_status, 4, true); 1008 1008 1009 1009 rpmodectl1 = I915_READ(GEN6_RP_CONTROL); 1010 1010 rcctl1 = I915_READ(GEN6_RC_CONTROL);
+5 -3
drivers/gpu/drm/i915/i915_trace.h
··· 406 406 TP_printk("plane=%d, obj=%p", __entry->plane, __entry->obj) 407 407 ); 408 408 409 - TRACE_EVENT(i915_reg_rw, 410 - TP_PROTO(bool write, u32 reg, u64 val, int len), 409 + TRACE_EVENT_CONDITION(i915_reg_rw, 410 + TP_PROTO(bool write, u32 reg, u64 val, int len, bool trace), 411 411 412 - TP_ARGS(write, reg, val, len), 412 + TP_ARGS(write, reg, val, len, trace), 413 + 414 + TP_CONDITION(trace), 413 415 414 416 TP_STRUCT__entry( 415 417 __field(u64, val)
+2 -2
drivers/gpu/drm/i915/intel_uncore.c
··· 359 359 val = __raw_i915_read##x(dev_priv, reg); \ 360 360 } \ 361 361 spin_unlock_irqrestore(&dev_priv->uncore.lock, irqflags); \ 362 - if (trace) trace_i915_reg_rw(false, reg, val, sizeof(val)); \ 362 + trace_i915_reg_rw(false, reg, val, sizeof(val), trace); \ 363 363 return val; \ 364 364 } 365 365 ··· 373 373 void i915_write##x(struct drm_i915_private *dev_priv, u32 reg, u##x val, bool trace) { \ 374 374 unsigned long irqflags; \ 375 375 u32 __fifo_ret = 0; \ 376 - if (trace) trace_i915_reg_rw(true, reg, val, sizeof(val)); \ 376 + trace_i915_reg_rw(true, reg, val, sizeof(val), trace); \ 377 377 spin_lock_irqsave(&dev_priv->uncore.lock, irqflags); \ 378 378 if (NEEDS_FORCE_WAKE((dev_priv), (reg))) { \ 379 379 __fifo_ret = __gen6_gt_wait_for_fifo(dev_priv); \