Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ata: Fix SATA_MOBILE_LPM_POLICY description in Kconfig

Improve the description of the possible default SATA link power
management policies and add the missing description for policy 5.
No functional changes.

Fixes: a5ec5a7bfd1f ("ata: ahci: Support state with min power but Partial low power state")
Cc: stable@vger.kernel.org
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Niklas Cassel <cassel@kernel.org>

+24 -8
+24 -8
drivers/ata/Kconfig
··· 117 117 118 118 config SATA_MOBILE_LPM_POLICY 119 119 int "Default SATA Link Power Management policy" 120 - range 0 4 120 + range 0 5 121 121 default 3 122 122 depends on SATA_AHCI 123 123 help 124 124 Select the Default SATA Link Power Management (LPM) policy to use 125 125 for chipsets / "South Bridges" supporting low-power modes. Such 126 126 chipsets are ubiquitous across laptops, desktops and servers. 127 + Each policy combines power saving states and features: 128 + - Partial: The Phy logic is powered but is in a reduced power 129 + state. The exit latency from this state is no longer than 130 + 10us). 131 + - Slumber: The Phy logic is powered but is in an even lower power 132 + state. The exit latency from this state is potentially 133 + longer, but no longer than 10ms. 134 + - DevSleep: The Phy logic may be powered down. The exit latency from 135 + this state is no longer than 20 ms, unless otherwise 136 + specified by DETO in the device Identify Device Data log. 137 + - HIPM: Host Initiated Power Management (host automatically 138 + transitions to partial and slumber). 139 + - DIPM: Device Initiated Power Management (device automatically 140 + transitions to partial and slumber). 127 141 128 - The value set has the following meanings: 142 + The possible values for the default SATA link power management 143 + policies are: 129 144 0 => Keep firmware settings 130 - 1 => Maximum performance 131 - 2 => Medium power 132 - 3 => Medium power with Device Initiated PM enabled 133 - 4 => Minimum power 145 + 1 => No power savings (maximum performance) 146 + 2 => HIPM (Partial) 147 + 3 => HIPM (Partial) and DIPM (Partial and Slumber) 148 + 4 => HIPM (Partial and DevSleep) and DIPM (Partial and Slumber) 149 + 5 => HIPM (Slumber and DevSleep) and DIPM (Partial and Slumber) 134 150 135 - Note "Minimum power" is known to cause issues, including disk 136 - corruption, with some disks and should not be used. 151 + Excluding the value 0, higher values represent policies with higher 152 + power savings. 137 153 138 154 config SATA_AHCI_PLATFORM 139 155 tristate "Platform AHCI SATA support"