Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ext3: Remove outdated comment about lock_super()

ext3_fill_super() is no longer called by read_super(), and it is no
longer called with the superblock locked. The
unlock_super()/lock_super() is no longer present, so this comment is
entirely superfluous.

Port of ext4 commit 32ed5058ce90024efcd811254b4b1de0468099df by
Theodore Ts'o <tytso@mit.edu>.

CC: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>

authored by

Eric Sandeen and committed by
Jan Kara
ed505ee4 dc52dd3a

+1 -8
+1 -8
fs/ext3/super.c
··· 2014 2014 } 2015 2015 2016 2016 ext3_setup_super (sb, es, sb->s_flags & MS_RDONLY); 2017 - /* 2018 - * akpm: core read_super() calls in here with the superblock locked. 2019 - * That deadlocks, because orphan cleanup needs to lock the superblock 2020 - * in numerous places. Here we just pop the lock - it's relatively 2021 - * harmless, because we are now ready to accept write_super() requests, 2022 - * and aviro says that's the only reason for hanging onto the 2023 - * superblock lock. 2024 - */ 2017 + 2025 2018 EXT3_SB(sb)->s_mount_state |= EXT3_ORPHAN_FS; 2026 2019 ext3_orphan_cleanup(sb, es); 2027 2020 EXT3_SB(sb)->s_mount_state &= ~EXT3_ORPHAN_FS;