Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rtnl/bond: don't send rtnl msg for unregistered iface

Before the patch, the command 'ip link add bond2 type bond mode 802.3ad'
causes the kernel to send a rtnl message for the bond2 interface, with an
ifindex 0.

'ip monitor' shows:
0: bond2: <BROADCAST,MULTICAST,MASTER> mtu 1500 state DOWN group default
link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
9: bond2@NONE: <BROADCAST,MULTICAST,MASTER> mtu 1500 qdisc noop state DOWN group default
link/ether ea:3e:1f:53:92:7b brd ff:ff:ff:ff:ff:ff
[snip]

The patch fixes the spotted bug by checking in bond driver if the interface
is registered before calling the notifier chain.
It also adds a check in rtmsg_ifinfo() to prevent this kind of bug in the
future.

Fixes: d4261e565000 ("bonding: create netlink event when bonding option is changed")
CC: Jiri Pirko <jiri@resnulli.us>
Reported-by: Julien Meunier <julien.meunier@6wind.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Nicolas Dichtel and committed by
David S. Miller
ed2a80ab 07ee0722

+4 -1
+1 -1
drivers/net/bonding/bond_options.c
··· 624 624 out: 625 625 if (ret) 626 626 bond_opt_error_interpret(bond, opt, ret, val); 627 - else 627 + else if (bond->dev->reg_state == NETREG_REGISTERED) 628 628 call_netdevice_notifiers(NETDEV_CHANGEINFODATA, bond->dev); 629 629 630 630 return ret;
+3
net/core/rtnetlink.c
··· 2416 2416 { 2417 2417 struct sk_buff *skb; 2418 2418 2419 + if (dev->reg_state != NETREG_REGISTERED) 2420 + return; 2421 + 2419 2422 skb = rtmsg_ifinfo_build_skb(type, dev, change, flags); 2420 2423 if (skb) 2421 2424 rtmsg_ifinfo_send(skb, dev, flags);