Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

reset: lpc18xx: simplify with dev_err_probe()

Use dev_err_probe() to avoid dmesg flood on actual defer. This makes
the code also simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
Link: https://lore.kernel.org/r/20240825-reset-cleanup-scoped-v1-4-03f6d834f8c0@linaro.org
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

authored by

Krzysztof Kozlowski and committed by
Philipp Zabel
ece222e9 3ec21e7f

+6 -8
+6 -8
drivers/reset/reset-lpc18xx.c
··· 151 151 return PTR_ERR(rc->base); 152 152 153 153 rc->clk_reg = devm_clk_get(&pdev->dev, "reg"); 154 - if (IS_ERR(rc->clk_reg)) { 155 - dev_err(&pdev->dev, "reg clock not found\n"); 156 - return PTR_ERR(rc->clk_reg); 157 - } 154 + if (IS_ERR(rc->clk_reg)) 155 + return dev_err_probe(&pdev->dev, PTR_ERR(rc->clk_reg), 156 + "reg clock not found\n"); 158 157 159 158 rc->clk_delay = devm_clk_get(&pdev->dev, "delay"); 160 - if (IS_ERR(rc->clk_delay)) { 161 - dev_err(&pdev->dev, "delay clock not found\n"); 162 - return PTR_ERR(rc->clk_delay); 163 - } 159 + if (IS_ERR(rc->clk_delay)) 160 + return dev_err_probe(&pdev->dev, PTR_ERR(rc->clk_delay), 161 + "delay clock not found\n"); 164 162 165 163 ret = clk_prepare_enable(rc->clk_reg); 166 164 if (ret) {