Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

parisc: stop using task->ptrace for {single,block}step flags

task->ptrace flags belong to generic code, so instead thief some
TIF_ bits to use. Somewhat risky conversion of code to test TASK_FLAGS
instead of TASK_PTRACE in assembly, but it looks alright in the end.

Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>

authored by

Kyle McMartin and committed by
Kyle McMartin
ecd3d4bc 2798af1a

+25 -18
+4
arch/parisc/include/asm/thread_info.h
··· 60 60 #define TIF_RESTORE_SIGMASK 6 /* restore saved signal mask */ 61 61 #define TIF_FREEZE 7 /* is freezing for suspend */ 62 62 #define TIF_NOTIFY_RESUME 8 /* callback before returning to user */ 63 + #define TIF_SINGLESTEP 9 /* single stepping? */ 64 + #define TIF_BLOCKSTEP 10 /* branch stepping? */ 63 65 64 66 #define _TIF_SYSCALL_TRACE (1 << TIF_SYSCALL_TRACE) 65 67 #define _TIF_SIGPENDING (1 << TIF_SIGPENDING) ··· 71 69 #define _TIF_RESTORE_SIGMASK (1 << TIF_RESTORE_SIGMASK) 72 70 #define _TIF_FREEZE (1 << TIF_FREEZE) 73 71 #define _TIF_NOTIFY_RESUME (1 << TIF_NOTIFY_RESUME) 72 + #define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP) 73 + #define _TIF_BLOCKSTEP (1 << TIF_BLOCKSTEP) 74 74 75 75 #define _TIF_USER_WORK_MASK (_TIF_SIGPENDING | _TIF_NOTIFY_RESUME | \ 76 76 _TIF_NEED_RESCHED | _TIF_RESTORE_SIGMASK)
+2 -2
arch/parisc/kernel/asm-offsets.c
··· 270 270 DEFINE(DTLB_OFF_COUNT, offsetof(struct pdc_cache_info, dt_off_count)); 271 271 DEFINE(DTLB_LOOP, offsetof(struct pdc_cache_info, dt_loop)); 272 272 BLANK(); 273 - DEFINE(PA_BLOCKSTEP_BIT, 31-PT_BLOCKSTEP_BIT); 274 - DEFINE(PA_SINGLESTEP_BIT, 31-PT_SINGLESTEP_BIT); 273 + DEFINE(TIF_BLOCKSTEP_PA_BIT, 31-TIF_BLOCKSTEP); 274 + DEFINE(TIF_SINGLESTEP_PA_BIT, 31-TIF_SINGLESTEP); 275 275 BLANK(); 276 276 DEFINE(ASM_PMD_SHIFT, PMD_SHIFT); 277 277 DEFINE(ASM_PGDIR_SHIFT, PGDIR_SHIFT);
+11 -10
arch/parisc/kernel/entry.S
··· 2047 2047 b,n syscall_check_sig 2048 2048 2049 2049 syscall_restore: 2050 - /* Are we being ptraced? */ 2051 2050 LDREG TI_TASK-THREAD_SZ_ALGN-FRAME_SIZE(%r30),%r1 2052 2051 2053 - ldw TASK_PTRACE(%r1), %r19 2054 - bb,< %r19,31,syscall_restore_rfi 2055 - nop 2052 + /* Are we being ptraced? */ 2053 + ldw TASK_FLAGS(%r1),%r19 2054 + ldi (_TIF_SINGLESTEP|_TIF_BLOCKSTEP),%r2 2055 + and,COND(=) %r19,%r2,%r0 2056 + b,n syscall_restore_rfi 2056 2057 2057 2058 ldo TASK_PT_FR31(%r1),%r19 /* reload fpregs */ 2058 2059 rest_fp %r19 ··· 2114 2113 ldi 0x0b,%r20 /* Create new PSW */ 2115 2114 depi -1,13,1,%r20 /* C, Q, D, and I bits */ 2116 2115 2117 - /* The values of PA_SINGLESTEP_BIT and PA_BLOCKSTEP_BIT are 2118 - * set in include/linux/ptrace.h and converted to PA bitmap 2116 + /* The values of SINGLESTEP_BIT and BLOCKSTEP_BIT are 2117 + * set in thread_info.h and converted to PA bitmap 2119 2118 * numbers in asm-offsets.c */ 2120 2119 2121 - /* if ((%r19.PA_SINGLESTEP_BIT)) { %r20.27=1} */ 2122 - extru,= %r19,PA_SINGLESTEP_BIT,1,%r0 2120 + /* if ((%r19.SINGLESTEP_BIT)) { %r20.27=1} */ 2121 + extru,= %r19,TIF_SINGLESTEP_PA_BIT,1,%r0 2123 2122 depi -1,27,1,%r20 /* R bit */ 2124 2123 2125 - /* if ((%r19.PA_BLOCKSTEP_BIT)) { %r20.7=1} */ 2126 - extru,= %r19,PA_BLOCKSTEP_BIT,1,%r0 2124 + /* if ((%r19.BLOCKSTEP_BIT)) { %r20.7=1} */ 2125 + extru,= %r19,TIF_BLOCKSTEP_PA_BIT,1,%r0 2127 2126 depi -1,7,1,%r20 /* T bit */ 2128 2127 2129 2128 STREG %r20,TASK_PT_PSW(%r1)
+8 -6
arch/parisc/kernel/ptrace.c
··· 36 36 */ 37 37 void ptrace_disable(struct task_struct *task) 38 38 { 39 - task->ptrace &= ~(PT_SINGLESTEP|PT_BLOCKSTEP); 39 + clear_tsk_thread_flag(task, TIF_SINGLESTEP); 40 + clear_tsk_thread_flag(task, TIF_BLOCKSTEP); 40 41 41 42 /* make sure the trap bits are not set */ 42 43 pa_psw(task)->r = 0; ··· 57 56 58 57 void user_enable_single_step(struct task_struct *task) 59 58 { 60 - task->ptrace &= ~PT_BLOCKSTEP; 61 - task->ptrace |= PT_SINGLESTEP; 59 + clear_tsk_thread_flag(task, TIF_BLOCKSTEP); 60 + set_tsk_thread_flag(task, TIF_SINGLESTEP); 62 61 63 62 if (pa_psw(task)->n) { 64 63 struct siginfo si; ··· 100 99 101 100 void user_enable_block_step(struct task_struct *task) 102 101 { 103 - task->ptrace &= ~PT_SINGLESTEP; 104 - task->ptrace |= PT_BLOCKSTEP; 102 + clear_tsk_thread_flag(task, TIF_SINGLESTEP); 103 + set_tsk_thread_flag(task, TIF_BLOCKSTEP); 105 104 106 105 /* Enable taken branch trap. */ 107 106 pa_psw(task)->r = 0; ··· 276 275 277 276 void do_syscall_trace_exit(struct pt_regs *regs) 278 277 { 279 - int stepping = !!(current->ptrace & (PT_SINGLESTEP|PT_BLOCKSTEP)); 278 + int stepping = test_thread_flag(TIF_SINGLESTEP) || 279 + test_thread_flag(TIF_BLOCKSTEP); 280 280 281 281 if (stepping || test_thread_flag(TIF_SYSCALL_TRACE)) 282 282 tracehook_report_syscall_exit(regs, stepping);