Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers: char: mem: fix IS_ERROR_VALUE usage

IS_ERR_VALUE macro should be used only with unsigned long type.
Specifically it works incorrectly with longer types.

The patch follows conclusion from discussion on LKML [1][2].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2120927
[2]: http://permalink.gmane.org/gmane.linux.kernel/2150581

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Andrzej Hajda and committed by
Greg Kroah-Hartman
ecb63a1b ba327173

+1 -1
+1 -1
drivers/char/mem.c
··· 695 695 offset += file->f_pos; 696 696 case SEEK_SET: 697 697 /* to avoid userland mistaking f_pos=-9 as -EBADF=-9 */ 698 - if (IS_ERR_VALUE((unsigned long long)offset)) { 698 + if ((unsigned long long)offset >= -MAX_ERRNO) { 699 699 ret = -EOVERFLOW; 700 700 break; 701 701 }