Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] media: ir-sony-decoder: 15bit function decode fix

The raw Sony IR decoder decodes 15bit messages slightly incorrectly.
To decode the function number, it shifts the bits right by 7 so that the
function is in bits 7:1, masks with 0xFD (0b11111101), and does an 8 bit
reverse so it ends up in bits 6:0. The mask should be 0xFE to correspond
with bits 7:1 (0b11111110).

The old mask had the effect of dropping the MSB of the function number
from bit 6, and leaving the LSB of the device number in bit 7.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

authored by

James Hogan and committed by
Mauro Carvalho Chehab
ec9ee8e2 fd0f6851

+1 -1
+1 -1
drivers/media/rc/ir-sony-decoder.c
··· 130 130 case 15: 131 131 device = bitrev8((data->bits >> 0) & 0xFF); 132 132 subdevice = 0; 133 - function = bitrev8((data->bits >> 7) & 0xFD); 133 + function = bitrev8((data->bits >> 7) & 0xFE); 134 134 break; 135 135 case 20: 136 136 device = bitrev8((data->bits >> 5) & 0xF8);