Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: convert remaining non-symbolic return values in ndo_start_xmit() functions

This patch converts the remaining occurences of raw return values to their
symbolic counterparts in ndo_start_xmit() functions that were missed by the
previous automatic conversion.

Additionally code that assumed the symbolic value of NETDEV_TX_OK to be zero
is changed to explicitly use NETDEV_TX_OK.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Patrick McHardy and committed by
David S. Miller
ec634fe3 a73e76e2

+116 -113
+1 -1
arch/xtensa/platforms/iss/network.c
··· 545 545 spin_unlock_irqrestore(&lp->lock, flags); 546 546 547 547 dev_kfree_skb(skb); 548 - return 0; 548 + return NETDEV_TX_OK; 549 549 } 550 550 551 551
+1 -1
drivers/isdn/hysdn/hysdn_net.c
··· 148 148 if (lp->sk_count <= 3) { 149 149 schedule_work(&((hysdn_card *) dev->ml_priv)->irq_queue); 150 150 } 151 - return (0); /* success */ 151 + return NETDEV_TX_OK; /* success */ 152 152 } /* net_send_packet */ 153 153 154 154
+2 -2
drivers/isdn/i4l/isdn_net.c
··· 1051 1051 isdn_net_dev *nd; 1052 1052 isdn_net_local *slp; 1053 1053 isdn_net_local *lp = (isdn_net_local *) netdev_priv(ndev); 1054 - int retv = 0; 1054 + int retv = NETDEV_TX_OK; 1055 1055 1056 1056 if (((isdn_net_local *) netdev_priv(ndev))->master) { 1057 1057 printk("isdn BUG at %s:%d!\n", __FILE__, __LINE__); 1058 1058 dev_kfree_skb(skb); 1059 - return 0; 1059 + return NETDEV_TX_OK; 1060 1060 } 1061 1061 1062 1062 /* For the other encaps the header has already been built */
+3 -3
drivers/isdn/i4l/isdn_ppp.c
··· 1223 1223 isdn_net_dev *nd; 1224 1224 unsigned int proto = PPP_IP; /* 0x21 */ 1225 1225 struct ippp_struct *ipt,*ipts; 1226 - int slot, retval = 0; 1226 + int slot, retval = NETDEV_TX_OK; 1227 1227 1228 1228 mlp = (isdn_net_local *) netdev_priv(netdev); 1229 1229 nd = mlp->netdev; /* get master lp */ ··· 1240 1240 if (!(ipts->pppcfg & SC_ENABLE_IP)) { /* PPP connected ? */ 1241 1241 if (ipts->debug & 0x1) 1242 1242 printk(KERN_INFO "%s: IP frame delayed.\n", netdev->name); 1243 - retval = 1; 1243 + retval = NETDEV_TX_BUSY; 1244 1244 goto out; 1245 1245 } 1246 1246 ··· 1261 1261 lp = isdn_net_get_locked_lp(nd); 1262 1262 if (!lp) { 1263 1263 printk(KERN_WARNING "%s: all channels busy - requeuing!\n", netdev->name); 1264 - retval = 1; 1264 + retval = NETDEV_TX_BUSY; 1265 1265 goto out; 1266 1266 } 1267 1267 /* we have our lp locked from now on */
+1 -1
drivers/net/3c501.c
··· 485 485 if (el_debug > 2) 486 486 pr_debug(" queued xmit.\n"); 487 487 dev_kfree_skb(skb); 488 - return 0; 488 + return NETDEV_TX_OK; 489 489 } 490 490 /* A receive upset our load, despite our best efforts */ 491 491 if (el_debug > 2)
+1 -1
drivers/net/7990.c
··· 585 585 lp->tx_full = 1; 586 586 spin_unlock_irqrestore (&lp->devlock, flags); 587 587 588 - return 0; 588 + return NETDEV_TX_OK; 589 589 } 590 590 EXPORT_SYMBOL_GPL(lance_start_xmit); 591 591
+2 -2
drivers/net/a2065.c
··· 553 553 volatile struct lance_regs *ll = lp->ll; 554 554 volatile struct lance_init_block *ib = lp->init_block; 555 555 int entry, skblen; 556 - int status = 0; 556 + int status = NETDEV_TX_OK; 557 557 unsigned long flags; 558 558 559 559 if (skb_padto(skb, ETH_ZLEN)) 560 - return 0; 560 + return NETDEV_TX_OK; 561 561 skblen = max_t(unsigned, skb->len, ETH_ZLEN); 562 562 563 563 local_irq_save(flags);
+1 -1
drivers/net/bonding/bond_3ad.c
··· 2431 2431 dev_kfree_skb(skb); 2432 2432 } 2433 2433 read_unlock(&bond->lock); 2434 - return 0; 2434 + return NETDEV_TX_OK; 2435 2435 } 2436 2436 2437 2437 int bond_3ad_lacpdu_recv(struct sk_buff *skb, struct net_device *dev, struct packet_type* ptype, struct net_device *orig_dev)
+1 -1
drivers/net/bonding/bond_alb.c
··· 1413 1413 } 1414 1414 read_unlock(&bond->curr_slave_lock); 1415 1415 read_unlock(&bond->lock); 1416 - return 0; 1416 + return NETDEV_TX_OK; 1417 1417 } 1418 1418 1419 1419 void bond_alb_monitor(struct work_struct *work)
+4 -4
drivers/net/bonding/bond_main.c
··· 4277 4277 dev_kfree_skb(skb); 4278 4278 } 4279 4279 read_unlock(&bond->lock); 4280 - return 0; 4280 + return NETDEV_TX_OK; 4281 4281 } 4282 4282 4283 4283 ··· 4308 4308 4309 4309 read_unlock(&bond->curr_slave_lock); 4310 4310 read_unlock(&bond->lock); 4311 - return 0; 4311 + return NETDEV_TX_OK; 4312 4312 } 4313 4313 4314 4314 /* ··· 4354 4354 dev_kfree_skb(skb); 4355 4355 } 4356 4356 read_unlock(&bond->lock); 4357 - return 0; 4357 + return NETDEV_TX_OK; 4358 4358 } 4359 4359 4360 4360 /* ··· 4414 4414 4415 4415 /* frame sent to all suitable interfaces */ 4416 4416 read_unlock(&bond->lock); 4417 - return 0; 4417 + return NETDEV_TX_OK; 4418 4418 } 4419 4419 4420 4420 /*------------------------- Device initialization ---------------------------*/
+3 -3
drivers/net/defxx.c
··· 3218 3218 bp->xmt_length_errors++; /* bump error counter */ 3219 3219 netif_wake_queue(dev); 3220 3220 dev_kfree_skb(skb); 3221 - return(0); /* return "success" */ 3221 + return NETDEV_TX_OK; /* return "success" */ 3222 3222 } 3223 3223 /* 3224 3224 * See if adapter link is available, if not, free buffer ··· 3241 3241 bp->xmt_discards++; /* bump error counter */ 3242 3242 dev_kfree_skb(skb); /* free sk_buff now */ 3243 3243 netif_wake_queue(dev); 3244 - return(0); /* return "success" */ 3244 + return NETDEV_TX_OK; /* return "success" */ 3245 3245 } 3246 3246 } 3247 3247 ··· 3345 3345 dfx_port_write_long(bp, PI_PDQ_K_REG_TYPE_2_PROD, bp->rcv_xmt_reg.lword); 3346 3346 spin_unlock_irqrestore(&bp->lock, flags); 3347 3347 netif_wake_queue(dev); 3348 - return(0); /* packet queued to adapter */ 3348 + return NETDEV_TX_OK; /* packet queued to adapter */ 3349 3349 } 3350 3350 3351 3351
+1 -1
drivers/net/depca.c
··· 1793 1793 static int load_packet(struct net_device *dev, struct sk_buff *skb) 1794 1794 { 1795 1795 struct depca_private *lp = netdev_priv(dev); 1796 - int i, entry, end, len, status = 0; 1796 + int i, entry, end, len, status = NETDEV_TX_OK; 1797 1797 1798 1798 entry = lp->tx_new; /* Ring around buffer number. */ 1799 1799 end = (entry + (skb->len - 1) / TX_BUFF_SZ) & lp->txRingMask;
+1 -1
drivers/net/ibm_newemac/core.c
··· 1342 1342 ++dev->stats.tx_packets; 1343 1343 dev->stats.tx_bytes += len; 1344 1344 1345 - return 0; 1345 + return NETDEV_TX_OK; 1346 1346 } 1347 1347 1348 1348 /* Tx lock BH */
+1 -1
drivers/net/ifb.c
··· 164 164 { 165 165 struct ifb_private *dp = netdev_priv(dev); 166 166 struct net_device_stats *stats = &dev->stats; 167 - int ret = 0; 167 + int ret = NETDEV_TX_OK; 168 168 u32 from = G_TC_FROM(skb->tc_verd); 169 169 170 170 stats->rx_packets++;
+2 -2
drivers/net/irda/ali-ircc.c
··· 1966 1966 1967 1967 IRDA_DEBUG(2, "%s(), ---------------- Start ----------------\n", __func__ ); 1968 1968 1969 - IRDA_ASSERT(dev != NULL, return 0;); 1969 + IRDA_ASSERT(dev != NULL, return NETDEV_TX_OK;); 1970 1970 1971 1971 self = netdev_priv(dev); 1972 - IRDA_ASSERT(self != NULL, return 0;); 1972 + IRDA_ASSERT(self != NULL, return NETDEV_TX_OK;); 1973 1973 1974 1974 iobase = self->io.sir_base; 1975 1975
+1 -1
drivers/net/irda/donauboe.c
··· 981 981 982 982 self = netdev_priv(dev); 983 983 984 - IRDA_ASSERT (self != NULL, return 0; ); 984 + IRDA_ASSERT (self != NULL, return NETDEV_TX_OK; ); 985 985 986 986 IRDA_DEBUG (1, "%s.tx:%x(%x)%x\n", __func__ 987 987 ,skb->len,self->txpending,INB (OBOE_ENABLEH));
+1 -1
drivers/net/irda/nsc-ircc.c
··· 1365 1365 1366 1366 self = netdev_priv(dev); 1367 1367 1368 - IRDA_ASSERT(self != NULL, return 0;); 1368 + IRDA_ASSERT(self != NULL, return NETDEV_TX_OK;); 1369 1369 1370 1370 iobase = self->io.fir_base; 1371 1371
+1 -1
drivers/net/irda/sir_dev.c
··· 590 590 int err; 591 591 s32 speed; 592 592 593 - IRDA_ASSERT(dev != NULL, return 0;); 593 + IRDA_ASSERT(dev != NULL, return NETDEV_TX_OK;); 594 594 595 595 netif_stop_queue(ndev); 596 596
+8 -8
drivers/net/irda/smsc-ircc2.c
··· 886 886 887 887 IRDA_DEBUG(1, "%s\n", __func__); 888 888 889 - IRDA_ASSERT(dev != NULL, return 0;); 889 + IRDA_ASSERT(dev != NULL, return NETDEV_TX_OK;); 890 890 891 891 self = netdev_priv(dev); 892 - IRDA_ASSERT(self != NULL, return 0;); 892 + IRDA_ASSERT(self != NULL, return NETDEV_TX_OK;); 893 893 894 894 netif_stop_queue(dev); 895 895 ··· 914 914 smsc_ircc_change_speed(self, speed); 915 915 spin_unlock_irqrestore(&self->lock, flags); 916 916 dev_kfree_skb(skb); 917 - return 0; 917 + return NETDEV_TX_OK; 918 918 } 919 919 self->new_speed = speed; 920 920 } ··· 935 935 936 936 dev_kfree_skb(skb); 937 937 938 - return 0; 938 + return NETDEV_TX_OK; 939 939 } 940 940 941 941 /* ··· 1190 1190 s32 speed; 1191 1191 int mtt; 1192 1192 1193 - IRDA_ASSERT(dev != NULL, return 0;); 1193 + IRDA_ASSERT(dev != NULL, return NETDEV_TX_OK;); 1194 1194 self = netdev_priv(dev); 1195 - IRDA_ASSERT(self != NULL, return 0;); 1195 + IRDA_ASSERT(self != NULL, return NETDEV_TX_OK;); 1196 1196 1197 1197 netif_stop_queue(dev); 1198 1198 ··· 1210 1210 smsc_ircc_change_speed(self, speed); 1211 1211 spin_unlock_irqrestore(&self->lock, flags); 1212 1212 dev_kfree_skb(skb); 1213 - return 0; 1213 + return NETDEV_TX_OK; 1214 1214 } 1215 1215 1216 1216 self->new_speed = speed; ··· 1242 1242 spin_unlock_irqrestore(&self->lock, flags); 1243 1243 dev_kfree_skb(skb); 1244 1244 1245 - return 0; 1245 + return NETDEV_TX_OK; 1246 1246 } 1247 1247 1248 1248 /*
+1 -1
drivers/net/irda/via-ircc.c
··· 832 832 __u32 speed; 833 833 834 834 self = netdev_priv(dev); 835 - IRDA_ASSERT(self != NULL, return 0;); 835 + IRDA_ASSERT(self != NULL, return NETDEV_TX_OK;); 836 836 iobase = self->io.fir_base; 837 837 838 838 netif_stop_queue(dev);
+1 -1
drivers/net/lib8390.c
··· 414 414 dev_kfree_skb (skb); 415 415 dev->stats.tx_bytes += send_length; 416 416 417 - return 0; 417 + return NETDEV_TX_OK; 418 418 } 419 419 420 420 /**
+1 -1
drivers/net/mlx4/en_tx.c
··· 764 764 /* Poll CQ here */ 765 765 mlx4_en_xmit_poll(priv, tx_ind); 766 766 767 - return 0; 767 + return NETDEV_TX_OK; 768 768 769 769 tx_drop: 770 770 dev_kfree_skb_any(skb);
+2 -2
drivers/net/myri10ge/myri10ge.c
··· 2968 2968 } 2969 2969 } 2970 2970 dev_kfree_skb_any(skb); 2971 - return 0; 2971 + return NETDEV_TX_OK; 2972 2972 2973 2973 drop: 2974 2974 ss = &mgp->ss[skb_get_queue_mapping(skb)]; 2975 2975 dev_kfree_skb_any(skb); 2976 2976 ss->stats.tx_dropped += 1; 2977 - return 0; 2977 + return NETDEV_TX_OK; 2978 2978 } 2979 2979 2980 2980 static struct net_device_stats *myri10ge_get_stats(struct net_device *dev)
+2 -2
drivers/net/ni52.c
··· 1183 1183 1184 1184 if (skb->len > XMIT_BUFF_SIZE) { 1185 1185 printk(KERN_ERR "%s: Sorry, max. framelength is %d bytes. The length of your frame is %d bytes.\n", dev->name, XMIT_BUFF_SIZE, skb->len); 1186 - return 0; 1186 + return NETDEV_TX_OK; 1187 1187 } 1188 1188 1189 1189 netif_stop_queue(dev); ··· 1267 1267 } 1268 1268 dev_kfree_skb(skb); 1269 1269 #endif 1270 - return 0; 1270 + return NETDEV_TX_OK; 1271 1271 } 1272 1272 1273 1273 /*******************************************
+1 -1
drivers/net/skfp/skfddi.c
··· 1077 1077 // dequeue packets from xmt queue and send them 1078 1078 netif_start_queue(dev); 1079 1079 dev_kfree_skb(skb); 1080 - return (0); /* return "success" */ 1080 + return NETDEV_TX_OK; /* return "success" */ 1081 1081 } 1082 1082 if (bp->QueueSkb == 0) { // return with tbusy set: queue full 1083 1083
+2 -2
drivers/net/sonic.c
··· 211 211 length = skb->len; 212 212 if (length < ETH_ZLEN) { 213 213 if (skb_padto(skb, ETH_ZLEN)) 214 - return 0; 214 + return NETDEV_TX_OK; 215 215 length = ETH_ZLEN; 216 216 } 217 217 ··· 265 265 266 266 dev->trans_start = jiffies; 267 267 268 - return 0; 268 + return NETDEV_TX_OK; 269 269 } 270 270 271 271 /*
+1 -1
drivers/net/tokenring/smctr.c
··· 4609 4609 if(tp->QueueSkb > 0) 4610 4610 netif_wake_queue(dev); 4611 4611 4612 - return (0); 4612 + return NETDEV_TX_OK; 4613 4613 } 4614 4614 4615 4615 static int smctr_send_lobe_media_test(struct net_device *dev)
+1 -1
drivers/net/tokenring/tms380tr.c
··· 682 682 tms380tr_exec_sifcmd(dev, CMD_TX_VALID); 683 683 spin_unlock_irqrestore(&tp->lock, flags); 684 684 685 - return 0; 685 + return NETDEV_TX_OK; 686 686 } 687 687 688 688 /*
+2 -2
drivers/net/tulip/dmfe.c
··· 676 676 if (skb->len > MAX_PACKET_SIZE) { 677 677 printk(KERN_ERR DRV_NAME ": big packet = %d\n", (u16)skb->len); 678 678 dev_kfree_skb(skb); 679 - return 0; 679 + return NETDEV_TX_OK; 680 680 } 681 681 682 682 spin_lock_irqsave(&db->lock, flags); ··· 722 722 /* free this SKB */ 723 723 dev_kfree_skb(skb); 724 724 725 - return 0; 725 + return NETDEV_TX_OK; 726 726 } 727 727 728 728
+2 -2
drivers/net/wan/dlci.c
··· 194 194 ret = 0; 195 195 196 196 if (!skb || !dev) 197 - return(0); 197 + return NETDEV_TX_OK; 198 198 199 199 dlp = netdev_priv(dev); 200 200 ··· 219 219 /* Alan Cox recommends always returning 0, and always freeing the packet */ 220 220 /* experience suggest a slightly more conservative approach */ 221 221 222 - if (!ret) 222 + if (ret == NETDEV_TX_OK) 223 223 { 224 224 dev_kfree_skb(skb); 225 225 netif_wake_queue(dev);
+1 -1
drivers/net/wan/dscc4.c
··· 1182 1182 if (dscc4_tx_quiescent(dpriv, dev)) 1183 1183 dscc4_do_tx(dpriv, dev); 1184 1184 1185 - return 0; 1185 + return NETDEV_TX_OK; 1186 1186 } 1187 1187 1188 1188 static int dscc4_close(struct net_device *dev)
+4 -4
drivers/net/wan/farsync.c
··· 2294 2294 dbg(DBG_ASS, 2295 2295 "Tried to transmit but no carrier on card %d port %d\n", 2296 2296 card->card_no, port->index); 2297 - return 0; 2297 + return NETDEV_TX_OK; 2298 2298 } 2299 2299 2300 2300 /* Drop it if it's too big! MTU failure ? */ ··· 2303 2303 LEN_TX_BUFFER); 2304 2304 dev_kfree_skb(skb); 2305 2305 dev->stats.tx_errors++; 2306 - return 0; 2306 + return NETDEV_TX_OK; 2307 2307 } 2308 2308 2309 2309 /* ··· 2337 2337 dev->stats.tx_errors++; 2338 2338 dbg(DBG_ASS, "Tx queue overflow card %d port %d\n", 2339 2339 card->card_no, port->index); 2340 - return 0; 2340 + return NETDEV_TX_OK; 2341 2341 } 2342 2342 2343 2343 /* ··· 2354 2354 fst_q_work_item(&fst_work_txq, card->card_no); 2355 2355 tasklet_schedule(&fst_tx_task); 2356 2356 2357 - return 0; 2357 + return NETDEV_TX_OK; 2358 2358 } 2359 2359 2360 2360 /*
+1 -1
drivers/net/wan/lmc/lmc_main.c
··· 1428 1428 lmc_softc_t *sc = dev_to_sc(dev); 1429 1429 u32 flag; 1430 1430 int entry; 1431 - int ret = 0; 1431 + int ret = NETDEV_TX_OK; 1432 1432 unsigned long flags; 1433 1433 1434 1434 lmc_trace(dev, "lmc_start_xmit in");
+1 -1
drivers/net/wan/wanxl.c
··· 310 310 } 311 311 312 312 spin_unlock(&port->lock); 313 - return 0; 313 + return NETDEV_TX_OK; 314 314 } 315 315 316 316
+21 -21
drivers/net/wireless/hostap/hostap_80211_tx.c
··· 75 75 printk(KERN_DEBUG "%s: hostap_data_start_xmit: short skb " 76 76 "(len=%d)\n", dev->name, skb->len); 77 77 kfree_skb(skb); 78 - return 0; 78 + return NETDEV_TX_OK; 79 79 } 80 80 81 81 if (local->ddev != dev) { ··· 89 89 printk(KERN_DEBUG "%s: prism2_tx: trying to use " 90 90 "AP device with Ethernet net dev\n", dev->name); 91 91 kfree_skb(skb); 92 - return 0; 92 + return NETDEV_TX_OK; 93 93 } 94 94 } else { 95 95 if (local->iw_mode == IW_MODE_REPEAT) { 96 96 printk(KERN_DEBUG "%s: prism2_tx: trying to use " 97 97 "non-WDS link in Repeater mode\n", dev->name); 98 98 kfree_skb(skb); 99 - return 0; 99 + return NETDEV_TX_OK; 100 100 } else if (local->iw_mode == IW_MODE_INFRA && 101 101 (local->wds_type & HOSTAP_WDS_AP_CLIENT) && 102 102 memcmp(skb->data + ETH_ALEN, dev->dev_addr, ··· 210 210 skb = skb_unshare(skb, GFP_ATOMIC); 211 211 if (skb == NULL) { 212 212 iface->stats.tx_dropped++; 213 - return 0; 213 + return NETDEV_TX_OK; 214 214 } 215 215 if (pskb_expand_head(skb, need_headroom, need_tailroom, 216 216 GFP_ATOMIC)) { 217 217 kfree_skb(skb); 218 218 iface->stats.tx_dropped++; 219 - return 0; 219 + return NETDEV_TX_OK; 220 220 } 221 221 } else if (skb_headroom(skb) < need_headroom) { 222 222 struct sk_buff *tmp = skb; ··· 224 224 kfree_skb(tmp); 225 225 if (skb == NULL) { 226 226 iface->stats.tx_dropped++; 227 - return 0; 227 + return NETDEV_TX_OK; 228 228 } 229 229 } else { 230 230 skb = skb_unshare(skb, GFP_ATOMIC); 231 231 if (skb == NULL) { 232 232 iface->stats.tx_dropped++; 233 - return 0; 233 + return NETDEV_TX_OK; 234 234 } 235 235 } 236 236 ··· 256 256 /* Send IEEE 802.11 encapsulated frame using the master radio device */ 257 257 skb->dev = local->dev; 258 258 dev_queue_xmit(skb); 259 - return 0; 259 + return NETDEV_TX_OK; 260 260 } 261 261 262 262 ··· 276 276 printk(KERN_DEBUG "%s: hostap_mgmt_start_xmit: short skb " 277 277 "(len=%d)\n", dev->name, skb->len); 278 278 kfree_skb(skb); 279 - return 0; 279 + return NETDEV_TX_OK; 280 280 } 281 281 282 282 iface->stats.tx_packets++; ··· 301 301 /* Send IEEE 802.11 encapsulated frame using the master radio device */ 302 302 skb->dev = local->dev; 303 303 dev_queue_xmit(skb); 304 - return 0; 304 + return NETDEV_TX_OK; 305 305 } 306 306 307 307 ··· 396 396 printk(KERN_DEBUG "%s: invalid skb->cb magic (0x%08x, " 397 397 "expected 0x%08x)\n", 398 398 dev->name, meta->magic, HOSTAP_SKB_TX_DATA_MAGIC); 399 - ret = 0; 399 + ret = NETDEV_TX_OK; 400 400 iface->stats.tx_dropped++; 401 401 goto fail; 402 402 } ··· 414 414 if (skb->len < 24) { 415 415 printk(KERN_DEBUG "%s: hostap_master_start_xmit: short skb " 416 416 "(len=%d)\n", dev->name, skb->len); 417 - ret = 0; 417 + ret = NETDEV_TX_OK; 418 418 iface->stats.tx_dropped++; 419 419 goto fail; 420 420 } ··· 441 441 dev->name, meta->ethertype); 442 442 hostap_dump_tx_80211(dev->name, skb); 443 443 444 - ret = 0; /* drop packet */ 444 + ret = NETDEV_TX_OK; /* drop packet */ 445 445 iface->stats.tx_dropped++; 446 446 goto fail; 447 447 } 448 448 break; 449 449 case AP_TX_DROP: 450 - ret = 0; /* drop packet */ 450 + ret = NETDEV_TX_OK; /* drop packet */ 451 451 iface->stats.tx_dropped++; 452 452 goto fail; 453 453 case AP_TX_RETRY: ··· 455 455 case AP_TX_BUFFERED: 456 456 /* do not free skb here, it will be freed when the 457 457 * buffered frame is sent/timed out */ 458 - ret = 0; 458 + ret = NETDEV_TX_OK; 459 459 goto tx_exit; 460 460 } 461 461 ··· 501 501 "frame (drop_unencrypted=1)\n", dev->name); 502 502 } 503 503 iface->stats.tx_dropped++; 504 - ret = 0; 504 + ret = NETDEV_TX_OK; 505 505 goto fail; 506 506 } 507 507 ··· 510 510 if (skb == NULL) { 511 511 printk(KERN_DEBUG "%s: TX - encryption failed\n", 512 512 dev->name); 513 - ret = 0; 513 + ret = NETDEV_TX_OK; 514 514 goto fail; 515 515 } 516 516 meta = (struct hostap_skb_tx_data *) skb->cb; ··· 519 519 "expected 0x%08x) after hostap_tx_encrypt\n", 520 520 dev->name, meta->magic, 521 521 HOSTAP_SKB_TX_DATA_MAGIC); 522 - ret = 0; 522 + ret = NETDEV_TX_OK; 523 523 iface->stats.tx_dropped++; 524 524 goto fail; 525 525 } 526 526 } 527 527 528 528 if (local->func->tx == NULL || local->func->tx(skb, dev)) { 529 - ret = 0; 529 + ret = NETDEV_TX_OK; 530 530 iface->stats.tx_dropped++; 531 531 } else { 532 - ret = 0; 532 + ret = NETDEV_TX_OK; 533 533 iface->stats.tx_packets++; 534 534 iface->stats.tx_bytes += skb->len; 535 535 } 536 536 537 537 fail: 538 - if (!ret && skb) 538 + if (ret == NETDEV_TX_OK && skb) 539 539 dev_kfree_skb(skb); 540 540 tx_exit: 541 541 if (tx.sta_ptr)
+2 -2
drivers/net/wireless/ipw2x00/libipw_tx.c
··· 527 527 if (ret == 0) { 528 528 dev->stats.tx_packets++; 529 529 dev->stats.tx_bytes += txb->payload_size; 530 - return 0; 530 + return NETDEV_TX_OK; 531 531 } 532 532 533 533 ieee80211_txb_free(txb); 534 534 } 535 535 536 - return 0; 536 + return NETDEV_TX_OK; 537 537 538 538 failed: 539 539 spin_unlock_irqrestore(&ieee->lock, flags);
+1 -1
drivers/net/wireless/prism54/islpci_eth.c
··· 234 234 /* unlock the driver code */ 235 235 spin_unlock_irqrestore(&priv->slock, flags); 236 236 237 - return 0; 237 + return NETDEV_TX_OK; 238 238 239 239 drop_free: 240 240 ndev->stats.tx_dropped++;
+1 -1
drivers/net/wireless/wavelan.c
··· 2891 2891 #ifdef DEBUG_TX_TRACE 2892 2892 printk(KERN_DEBUG "%s: <-wavelan_packet_xmit()\n", dev->name); 2893 2893 #endif 2894 - return 0; 2894 + return NETDEV_TX_OK; 2895 2895 } 2896 2896 2897 2897 /*********************** HARDWARE CONFIGURATION ***********************/
+2 -2
drivers/net/wireless/wavelan_cs.c
··· 3113 3113 * able to detect collisions, therefore in theory we don't really 3114 3114 * need to pad. Jean II */ 3115 3115 if (skb_padto(skb, ETH_ZLEN)) 3116 - return 0; 3116 + return NETDEV_TX_OK; 3117 3117 3118 3118 wv_packet_write(dev, skb->data, skb->len); 3119 3119 ··· 3122 3122 #ifdef DEBUG_TX_TRACE 3123 3123 printk(KERN_DEBUG "%s: <-wavelan_packet_xmit()\n", dev->name); 3124 3124 #endif 3125 - return(0); 3125 + return NETDEV_TX_OK; 3126 3126 } 3127 3127 3128 3128 /********************** HARDWARE CONFIGURATION **********************/
+1 -2
drivers/net/wireless/wl3501_cs.c
··· 1348 1348 if (rc) { 1349 1349 ++dev->stats.tx_dropped; 1350 1350 netif_stop_queue(dev); 1351 - rc = NETDEV_TX_OK; 1352 1351 } else { 1353 1352 ++dev->stats.tx_packets; 1354 1353 dev->stats.tx_bytes += skb->len; ··· 1357 1358 netif_stop_queue(dev); 1358 1359 } 1359 1360 spin_unlock_irqrestore(&this->lock, flags); 1360 - return rc; 1361 + return NETDEV_TX_OK; 1361 1362 } 1362 1363 1363 1364 static int wl3501_open(struct net_device *dev)
+2
drivers/s390/net/claw.c
··· 350 350 CLAW_DBF_TEXT_(4, trace, "clawtx%d", rc); 351 351 if (rc) 352 352 rc = NETDEV_TX_BUSY; 353 + else 354 + rc = NETDEV_TX_OK; 353 355 return rc; 354 356 } /* end of claw_tx */ 355 357
+4 -4
drivers/s390/net/lcs.c
··· 1553 1553 struct net_device *dev) 1554 1554 { 1555 1555 struct lcs_header *header; 1556 - int rc = 0; 1556 + int rc = NETDEV_TX_OK; 1557 1557 1558 1558 LCS_DBF_TEXT(5, trace, "hardxmit"); 1559 1559 if (skb == NULL) { 1560 1560 card->stats.tx_dropped++; 1561 1561 card->stats.tx_errors++; 1562 - return 0; 1562 + return NETDEV_TX_OK; 1563 1563 } 1564 1564 if (card->state != DEV_STATE_UP) { 1565 1565 dev_kfree_skb(skb); 1566 1566 card->stats.tx_dropped++; 1567 1567 card->stats.tx_errors++; 1568 1568 card->stats.tx_carrier_errors++; 1569 - return 0; 1569 + return NETDEV_TX_OK; 1570 1570 } 1571 1571 if (skb->protocol == htons(ETH_P_IPV6)) { 1572 1572 dev_kfree_skb(skb); 1573 - return 0; 1573 + return NETDEV_TX_OK; 1574 1574 } 1575 1575 netif_stop_queue(card->dev); 1576 1576 spin_lock(&card->lock);
+3 -3
drivers/s390/net/netiucv.c
··· 1376 1376 if (skb == NULL) { 1377 1377 IUCV_DBF_TEXT(data, 2, "netiucv_tx: skb is NULL\n"); 1378 1378 privptr->stats.tx_dropped++; 1379 - return 0; 1379 + return NETDEV_TX_OK; 1380 1380 } 1381 1381 if (skb_headroom(skb) < NETIUCV_HDRLEN) { 1382 1382 IUCV_DBF_TEXT(data, 2, 1383 1383 "netiucv_tx: skb_headroom < NETIUCV_HDRLEN\n"); 1384 1384 dev_kfree_skb(skb); 1385 1385 privptr->stats.tx_dropped++; 1386 - return 0; 1386 + return NETDEV_TX_OK; 1387 1387 } 1388 1388 1389 1389 /** ··· 1395 1395 privptr->stats.tx_dropped++; 1396 1396 privptr->stats.tx_errors++; 1397 1397 privptr->stats.tx_carrier_errors++; 1398 - return 0; 1398 + return NETDEV_TX_OK; 1399 1399 } 1400 1400 1401 1401 if (netiucv_test_and_set_busy(dev)) {
+1
drivers/s390/net/qeth_l2_main.c
··· 744 744 card->stats.tx_bytes += tx_bytes; 745 745 if (new_skb != skb) 746 746 dev_kfree_skb_any(skb); 747 + rc = NETDEV_TX_OK; 747 748 } else { 748 749 if (data_offset >= 0) 749 750 kmem_cache_free(qeth_core_header_cache, hdr);
+1
drivers/s390/net/qeth_l3_main.c
··· 2793 2793 card->perf_stats.sg_frags_sent += nr_frags + 1; 2794 2794 } 2795 2795 } 2796 + rc = NETDEV_TX_OK; 2796 2797 } else { 2797 2798 if (data_offset >= 0) 2798 2799 kmem_cache_free(qeth_core_header_cache, hdr);
+3 -3
drivers/staging/rt2860/rt_main_dev.c
··· 862 862 { 863 863 struct net_device *net_dev = skb->dev; 864 864 PRTMP_ADAPTER pAd = net_dev->ml_priv; 865 - int status = 0; 865 + int status = NETDEV_TX_OK; 866 866 PNDIS_PACKET pPacket = (PNDIS_PACKET) skb; 867 867 868 868 { ··· 892 892 893 893 STASendPackets((NDIS_HANDLE)pAd, (PPNDIS_PACKET) &pPacket, 1); 894 894 895 - status = 0; 895 + status = NETDEV_TX_OK; 896 896 done: 897 897 898 898 return status; ··· 923 923 if (!(net_dev->flags & IFF_UP)) 924 924 { 925 925 RELEASE_NDIS_PACKET(pAd, (PNDIS_PACKET)skb_p, NDIS_STATUS_FAILURE); 926 - return 0; 926 + return NETDEV_TX_OK; 927 927 } 928 928 929 929 NdisZeroMemory((PUCHAR)&skb_p->cb[CB_OFF], 15);
+2 -2
drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
··· 802 802 if ((*ieee->hard_start_xmit)(txb, dev) == 0) { 803 803 stats->tx_packets++; 804 804 stats->tx_bytes += txb->payload_size; 805 - return 0; 805 + return NETDEV_TX_OK; 806 806 } 807 807 ieee80211_txb_free(txb); 808 808 } 809 809 } 810 810 811 - return 0; 811 + return NETDEV_TX_OK; 812 812 813 813 failed: 814 814 spin_unlock_irqrestore(&ieee->lock, flags);
+2 -2
drivers/staging/rtl8187se/r8180_core.c
··· 3040 3040 spin_unlock_irqrestore(&priv->tx_lock,flags); 3041 3041 3042 3042 dev_kfree_skb_any(skb); 3043 - return 0; 3043 + return NETDEV_TX_OK; 3044 3044 } 3045 3045 3046 3046 rtl8180_tx(dev, skb->data, skb->len, priority, ··· 3051 3051 spin_unlock_irqrestore(&priv->tx_lock,flags); 3052 3052 3053 3053 dev_kfree_skb_any(skb); 3054 - return 0; 3054 + return NETDEV_TX_OK; 3055 3055 } 3056 3056 3057 3057 // longpre 144+48 shortpre 72+24
+1 -1
drivers/staging/wlan-ng/p80211netdev.c
··· 354 354 p80211_metawep_t p80211_wep; 355 355 356 356 if (skb == NULL) 357 - return 0; 357 + return NETDEV_TX_OK; 358 358 359 359 if (wlandev->state != WLAN_DEVICE_OPEN) { 360 360 result = 1;
+1 -1
net/atm/mpc.c
··· 554 554 while (i < mpc->number_of_mps_macs) { 555 555 if (!compare_ether_addr(eth->h_dest, (mpc->mps_macs + i*ETH_ALEN))) 556 556 if ( send_via_shortcut(skb, mpc) == 0 ) /* try shortcut */ 557 - return 0; /* success! */ 557 + return NETDEV_TX_OK; /* success! */ 558 558 i++; 559 559 } 560 560
+3 -3
net/core/dev.c
··· 1704 1704 skb_dst_drop(skb); 1705 1705 1706 1706 rc = ops->ndo_start_xmit(skb, dev); 1707 - if (rc == 0) 1707 + if (rc == NETDEV_TX_OK) 1708 1708 txq_trans_update(txq); 1709 1709 /* 1710 1710 * TODO: if skb_orphan() was called by ··· 1730 1730 skb->next = nskb->next; 1731 1731 nskb->next = NULL; 1732 1732 rc = ops->ndo_start_xmit(nskb, dev); 1733 - if (unlikely(rc)) { 1733 + if (unlikely(rc != NETDEV_TX_OK)) { 1734 1734 nskb->next = skb->next; 1735 1735 skb->next = nskb; 1736 1736 return rc; ··· 1744 1744 1745 1745 out_kfree_skb: 1746 1746 kfree_skb(skb); 1747 - return 0; 1747 + return NETDEV_TX_OK; 1748 1748 } 1749 1749 1750 1750 static u32 skb_tx_hashrnd;
+6 -6
net/mac80211/tx.c
··· 1627 1627 u32 sta_flags = 0; 1628 1628 1629 1629 if (unlikely(skb->len < ETH_HLEN)) { 1630 - ret = 0; 1630 + ret = NETDEV_TX_OK; 1631 1631 goto fail; 1632 1632 } 1633 1633 ··· 1664 1664 if (!sdata->u.mesh.mshcfg.dot11MeshTTL) { 1665 1665 /* Do not send frames with mesh_ttl == 0 */ 1666 1666 sdata->u.mesh.mshstats.dropped_frames_ttl++; 1667 - ret = 0; 1667 + ret = NETDEV_TX_OK; 1668 1668 goto fail; 1669 1669 } 1670 1670 memset(&mesh_hdr, 0, sizeof(mesh_hdr)); ··· 1724 1724 hdrlen = 24; 1725 1725 break; 1726 1726 default: 1727 - ret = 0; 1727 + ret = NETDEV_TX_OK; 1728 1728 goto fail; 1729 1729 } 1730 1730 ··· 1766 1766 1767 1767 I802_DEBUG_INC(local->tx_handlers_drop_unauth_port); 1768 1768 1769 - ret = 0; 1769 + ret = NETDEV_TX_OK; 1770 1770 goto fail; 1771 1771 } 1772 1772 ··· 1858 1858 dev->trans_start = jiffies; 1859 1859 dev_queue_xmit(skb); 1860 1860 1861 - return 0; 1861 + return NETDEV_TX_OK; 1862 1862 1863 1863 fail: 1864 - if (!ret) 1864 + if (ret == NETDEV_TX_OK) 1865 1865 dev_kfree_skb(skb); 1866 1866 1867 1867 return ret;