Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio: uniphier: Replace zero-length array with flexible-array member

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
int stuff;
struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

authored by

Gustavo A. R. Silva and committed by
Bartosz Golaszewski
ec18d7e7 869233f8

+1 -1
+1 -1
drivers/gpio/gpio-uniphier.c
··· 30 30 struct irq_domain *domain; 31 31 void __iomem *regs; 32 32 spinlock_t lock; 33 - u32 saved_vals[0]; 33 + u32 saved_vals[]; 34 34 }; 35 35 36 36 static unsigned int uniphier_gpio_bank_to_reg(unsigned int bank)