PCI: fix reference leak in pci_get_dev_by_id()

Alex Chiang and Matthew Wilcox pointed out that pci_get_dev_by_id() does
not properly decrement the reference on the from pointer if it is
present, like the documentation for the function states it will.

It fixes a pretty bad leak in the hotplug core (we were leaking an
entire struct pci_dev for each function of each offlined card, the first
time around; subsequent onlines/offlines were ok).

Cc: Matthew Wilcox <matthew@wil.cx>
Cc: stable <stable@kernel.org>
Tested-by: Alex Chiang <achiang@hp.com>
Acked-by: Alex Chiang <achiang@hp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

authored by Greg KH and committed by Jesse Barnes ebca4f1b d6a9e9b4

+2
+2
drivers/pci/search.c
··· 280 280 match_pci_dev_by_id); 281 281 if (dev) 282 282 pdev = to_pci_dev(dev); 283 + if (from) 284 + pci_dev_put(from); 283 285 return pdev; 284 286 } 285 287