Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: chipidea: tegra: Consistently use dev_err_probe()

Convert all error exits from probe() to dev_err_probe().

Acked-by: Peter Chen <peter.chen@kernel.org>
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Link: https://lore.kernel.org/r/43d03aad1c394d9995f69d13ca1176f9ff8a8dab.1695934946.git.mirq-linux@rere.qmqm.pl
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Michał Mirosław and committed by
Greg Kroah-Hartman
eb9c996f 2ae61a25

+7 -9
+7 -9
drivers/usb/chipidea/ci_hdrc_tegra.c
··· 293 293 usb->phy = devm_usb_get_phy_by_phandle(&pdev->dev, "nvidia,phy", 0); 294 294 if (IS_ERR(usb->phy)) 295 295 return dev_err_probe(&pdev->dev, PTR_ERR(usb->phy), 296 - "failed to get PHY\n"); 296 + "failed to get PHY"); 297 297 298 298 usb->clk = devm_clk_get(&pdev->dev, NULL); 299 - if (IS_ERR(usb->clk)) { 300 - err = PTR_ERR(usb->clk); 301 - dev_err(&pdev->dev, "failed to get clock: %d\n", err); 302 - return err; 303 - } 299 + if (IS_ERR(usb->clk)) 300 + return dev_err_probe(&pdev->dev, PTR_ERR(usb->clk), 301 + "failed to get clock"); 304 302 305 303 err = devm_tegra_core_dev_init_opp_table_common(&pdev->dev); 306 304 if (err) ··· 314 316 315 317 err = tegra_usb_reset_controller(&pdev->dev); 316 318 if (err) { 317 - dev_err(&pdev->dev, "failed to reset controller: %d\n", err); 319 + dev_err_probe(&pdev->dev, err, "failed to reset controller"); 318 320 goto fail_power_off; 319 321 } 320 322 ··· 345 347 usb->dev = ci_hdrc_add_device(&pdev->dev, pdev->resource, 346 348 pdev->num_resources, &usb->data); 347 349 if (IS_ERR(usb->dev)) { 348 - err = PTR_ERR(usb->dev); 349 - dev_err(&pdev->dev, "failed to add HDRC device: %d\n", err); 350 + err = dev_err_probe(&pdev->dev, PTR_ERR(usb->dev), 351 + "failed to add HDRC device"); 350 352 goto phy_shutdown; 351 353 } 352 354