devres: WARN() and return, don't crash on device_del() of uninitialized device

I just debugged an obscure crash caused by a device_del() of a all NULL'd
out struct device (in usb-serial) and found that a patch like this one would
have saved me time (in addition to improved chances of a bug report from
users hitting similar driver bugs).

[akpm@linux-foundation.org: cleanup]
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

authored by Benjamin Herrenschmidt and committed by Greg Kroah-Hartman eb8d3c60 81e4e1ba

+3
+3
drivers/base/devres.c
··· 428 428 { 429 429 unsigned long flags; 430 430 431 + /* Looks like an uninitialized device structure */ 432 + if (WARN_ON(dev->devres_head.next == NULL)) 433 + return -ENODEV; 431 434 spin_lock_irqsave(&dev->devres_lock, flags); 432 435 return release_nodes(dev, dev->devres_head.next, &dev->devres_head, 433 436 flags);