Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

firmware: cs_dsp: FW_CS_DSP_KUNIT_TEST should not select REGMAP

Enabling a (modular) test should not silently enable additional kernel
functionality, as that may increase the attack vector of a product.

Fix this by making FW_CS_DSP_KUNIT_TEST (and FW_CS_DSP_KUNIT_TEST_UTILS)
depend on REGMAP instead of selecting it.

After this, one can safely enable CONFIG_KUNIT_ALL_TESTS=m to build
modules for all appropriate tests for ones system, without pulling in
extra unwanted functionality, while still allowing a tester to manually
enable REGMAP_BUILD and this test suite on a system where REGMAP is not
enabled by default.

Fixes: dd0b6b1f29b92202 ("firmware: cs_dsp: Add KUnit testing of bin file download")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Link: https://patch.msgid.link/73c81ac85e21f1c5a75b7628d90cbb0e1b4ed0fa.1737833376.git.geert@linux-m68k.org
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Geert Uytterhoeven and committed by
Mark Brown
eb5c7982 2e3c688d

+2 -4
+2 -4
drivers/firmware/cirrus/Kconfig
··· 6 6 7 7 config FW_CS_DSP_KUNIT_TEST_UTILS 8 8 tristate 9 - depends on KUNIT 10 - select REGMAP 9 + depends on KUNIT && REGMAP 11 10 select FW_CS_DSP 12 11 13 12 config FW_CS_DSP_KUNIT_TEST 14 13 tristate "KUnit tests for Cirrus Logic cs_dsp" if !KUNIT_ALL_TESTS 15 - depends on KUNIT 14 + depends on KUNIT && REGMAP 16 15 default KUNIT_ALL_TESTS 17 - select REGMAP 18 16 select FW_CS_DSP 19 17 select FW_CS_DSP_KUNIT_TEST_UTILS 20 18 help